File tablestakes.rb has 367 lines of code (exceeds 250 allowed). Consider refactoring. Open
class Table
# The headers attribute contains the table headers used to reference
# columns in the +Table+. All headers are represented as +String+ types.
# Class Table has 33 methods (exceeds 20 allowed). Consider refactoring. Open
class Table
# The headers attribute contains the table headers used to reference
# columns in the +Table+. All headers are represented as +String+ types.
# Method count has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def count(colname=nil, value=nil)
if colname.nil? || value.nil?
if @table.size > 0
@table.each_key {|e| return @table.fetch(e).length }
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method select has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def select(*columns)
# check arguments
raise ArgumentError, "Invalid column name(s)" unless columns
columns.kind_of?(Array) ? columns.flatten! : nil
columns.each do |c|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sub has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def sub(colname, match=nil, replace=nil, &block)
# check arguments
raise ArgumentError, "No regular expression to match against" unless match || block_given?
raise ArgumentError, "Invalid column name" unless @table.has_key?(colname)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method join has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def join(table2, colname, col2name=colname)
# check arguments
raise ArgumentError, "Invalid table!" unless table2.is_a?(Table)
raise ArgumentError, "Invalid column name" unless @table.has_key?(colname)
raise ArgumentError, "Invalid column name" unless table2.headers.include?(col2name)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method where has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def where(colname, condition=nil)
# check arguments
raise ArgumentError, "Invalid Column Name" unless @headers.include?(colname)
result = []- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_row has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add_row(*row)
if row.kind_of? Array
row = row.flatten
end
if @headers.empty?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method union has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def union(table2, colname, col2name=colname)
# check arguments
raise ArgumentError, "Invalid table!" unless table2.is_a?(Table)
raise ArgumentError, "Invalid column name" unless @table.has_key?(colname)
raise ArgumentError, "Invalid column name" unless table2.headers.include?(col2name)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def each
if block_given?
@table[@headers.first].each_index do |index|
nextrow = []- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method rename_header has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def rename_header(orig_name, new_name)
raise ArgumentError, "Original Column name type invalid" unless orig_name.kind_of? String
raise ArgumentError, "New Column name type invalid" unless new_name.kind_of? String
raise ArgumentError, "Column Name does not exist!" unless @headers.include? orig_name
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method intersect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def intersect(table2, colname, col2name=colname)
# check arguments
raise ArgumentError, "Invalid table!" unless table2.is_a?(Table)
raise ArgumentError, "Invalid column name" unless @table.has_key?(colname)
raise ArgumentError, "Invalid column name" unless table2.headers.include?(col2name)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def read_file(filename)
file = File.open(filename, "r")
result = []
file.each_line do |line|
result << line.chomp.split("\t")- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
def union(table2, colname, col2name=colname)
# check arguments
raise ArgumentError, "Invalid table!" unless table2.is_a?(Table)
raise ArgumentError, "Invalid column name" unless @table.has_key?(colname)
raise ArgumentError, "Invalid column name" unless table2.headers.include?(col2name)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 34.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
def intersect(table2, colname, col2name=colname)
# check arguments
raise ArgumentError, "Invalid table!" unless table2.is_a?(Table)
raise ArgumentError, "Invalid column name" unless @table.has_key?(colname)
raise ArgumentError, "Invalid column name" unless table2.headers.include?(col2name)- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 34.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76