Sign upLogin

jdel/gosspks

View on GitHub
Star
handler/v1/v1.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function buildFromFiles has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Open

func buildFromFiles(r *http.Request, files []os.FileInfo) (syno.Packages, error) {
    var synoPkgs = make(syno.Packages, 0)
    cfg.SynoOptions.Language = r.URL.Query().Get("language")

    loggerV1.Debug("Processing ", len(files), " files")
Severity: Minor
Found in handler/v1/v1.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildFromFiles has 79 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func buildFromFiles(r *http.Request, files []os.FileInfo) (syno.Packages, error) {
    var synoPkgs = make(syno.Packages, 0)
    cfg.SynoOptions.Language = r.URL.Query().Get("language")

    loggerV1.Debug("Processing ", len(files), " files")
Severity: Major
Found in handler/v1/v1.go - About 2 hrs to fix

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package v1 // import jdel.org/gosspks/v1
    Severity: Minor
    Found in handler/v1/v1.go by gofmt

    There are no issues that match your filters.

    Category
    Status