Sign upLogin

jdel/gosspks

View on GitHub
Star

Showing 21 of 21 total issues

Function buildFromFiles has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Open

func buildFromFiles(r *http.Request, files []os.FileInfo) (syno.Packages, error) {
    var synoPkgs = make(syno.Packages, 0)
    cfg.SynoOptions.Language = r.URL.Query().Get("language")

    loggerV1.Debug("Processing ", len(files), " files")
Severity: Minor
Found in handler/v1/v1.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function RouteSynology has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func RouteSynology(w http.ResponseWriter, r *http.Request) {
    var synoPkgs syno.Packages
    var err error
    var paramLanguage,
        paramTimezone,
Severity: Major
Found in handler/v1/routeSynology.go - About 2 hrs to fix

    Function buildFromFiles has 79 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func buildFromFiles(r *http.Request, files []os.FileInfo) (syno.Packages, error) {
    var synoPkgs = make(syno.Packages, 0)
    cfg.SynoOptions.Language = r.URL.Query().Get("language")

    loggerV1.Debug("Processing ", len(files), " files")
    Severity: Major
    Found in handler/v1/v1.go - About 2 hrs to fix

      Function InitConfig has 63 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func InitConfig(cfgFile string, homeDir string) {
    // Instantiate goSSPKSHome ASAP
    goSSPKSHome = getOrCreateHome(homeDir)

    if cfgFile != "" {
      Severity: Minor
      Found in cfg/cfg.go - About 1 hr to fix

        Function RouteSynofficial has 63 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func RouteSynofficial(w http.ResponseWriter, r *http.Request) {
    var synoPkgs syno.Packages
    var err error
    var scheme = getScheme(r)
    var paramLanguage,
        Severity: Minor
        Found in handler/v1/routeSynofficial.go - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func GetPackagesCacheDuration() time.Duration {
    var err error
    packagesDuration := viper.GetString("gosspks.cache.packages.duration")
    cacheDuration := cache.DefaultCacheDuration
    if cacheDuration, err = time.ParseDuration(packagesDuration); err != nil {
          Severity: Minor
          Found in cfg/cfg.go and 1 other location - About 35 mins to fix
          cfg/cfg.go on lines 231..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func GetModelsCacheDuration() time.Duration {
    var err error
    modelsDuration := viper.GetString("gosspks.cache.models.duration")
    cacheDuration := cache.DefaultCacheDuration
    if cacheDuration, err = time.ParseDuration(modelsDuration); err != nil {
          Severity: Minor
          Found in cfg/cfg.go and 1 other location - About 35 mins to fix
          cfg/cfg.go on lines 206..215

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package v1 // import jdel.org/gosspks/v1
          Severity: Minor
          Found in handler/v1/routeModels.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package v1 // import jdel.org/gosspks/v1
          Severity: Minor
          Found in handler/v1/routeSynology.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package v1 // import jdel.org/gosspks/v1
          Severity: Minor
          Found in handler/v1/routeSynofficial.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package cmd // import jdel.org/gosspks/cmd
          Severity: Minor
          Found in cmd/cmd.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package lgr // import jdel.org/gosspks/lgr
          Severity: Minor
          Found in lgr/lgr.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package cmd // import jdel.org/gosspks/cmd
          Severity: Minor
          Found in cmd/version.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package rtr // import jdel.org/gosspks/rtr
          Severity: Minor
          Found in rtr/rtr.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package util // import jdel.org/gosspks/util
          Severity: Minor
          Found in util/filesystem.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package cfg // import jdel.org/gosspks/cfg
          Severity: Minor
          Found in cfg/cfg.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package v1 // import jdel.org/gosspks/v1
          Severity: Minor
          Found in handler/v1/v1.go by gofmt

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package handler // import jdel.org/gosspks/handler
          Severity: Minor
          Found in handler/routeAbout.go by gofmt

          2: cannot find package "github.com/patrickmn/go-cache" in any of:
          Open

              "github.com/patrickmn/go-cache"
          Severity: Minor
          Found in cache/cache.go by govet

          Your code does not pass gofmt in 1 place. Go fmt your code!
          Open

          package v1 // import jdel.org/gosspks/v1
          Severity: Minor
          Found in handler/v1/routePackage.go by gofmt
          Severity
          Category
          Status
          Source
          Language