Sign upLogin

jdel/gosspks

View on GitHub
Star

Showing 5 of 21 total issues

Function buildFromFiles has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Open

func buildFromFiles(r *http.Request, files []os.FileInfo) (syno.Packages, error) {
    var synoPkgs = make(syno.Packages, 0)
    cfg.SynoOptions.Language = r.URL.Query().Get("language")

    loggerV1.Debug("Processing ", len(files), " files")
Severity: Minor
Found in handler/v1/v1.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function RouteSynology has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func RouteSynology(w http.ResponseWriter, r *http.Request) {
    var synoPkgs syno.Packages
    var err error
    var paramLanguage,
        paramTimezone,
Severity: Major
Found in handler/v1/routeSynology.go - About 2 hrs to fix

    Function buildFromFiles has 79 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func buildFromFiles(r *http.Request, files []os.FileInfo) (syno.Packages, error) {
    var synoPkgs = make(syno.Packages, 0)
    cfg.SynoOptions.Language = r.URL.Query().Get("language")

    loggerV1.Debug("Processing ", len(files), " files")
    Severity: Major
    Found in handler/v1/v1.go - About 2 hrs to fix

      Function InitConfig has 63 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func InitConfig(cfgFile string, homeDir string) {
    // Instantiate goSSPKSHome ASAP
    goSSPKSHome = getOrCreateHome(homeDir)

    if cfgFile != "" {
      Severity: Minor
      Found in cfg/cfg.go - About 1 hr to fix

        Function RouteSynofficial has 63 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func RouteSynofficial(w http.ResponseWriter, r *http.Request) {
    var synoPkgs syno.Packages
    var err error
    var scheme = getScheme(r)
    var paramLanguage,
        Severity: Minor
        Found in handler/v1/routeSynofficial.go - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language