Function save has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
public function save() {
// create dir for data if it does not exists
$counter = 0;
while (true) {
$this->set('id', $this->generateNewId());- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method restore has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function restore($id) {
if (!static::isValidId($id)) {
throw new Exception($id . ' is not a valid id');
}
Method save has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function save() {
// create dir for data if it does not exists
$counter = 0;
while (true) {
$this->set('id', $this->generateNewId());Function isValidSJCL has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
private static function isValidSJCL($jsonstring) {
$accepted_keys=array('iv','v','iter','ks','ts','mode','adata','cipher','salt','ct');
// Make sure content is valid json
$decoded = json_decode($jsonstring);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function restore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public static function restore($id) {
if (!static::isValidId($id)) {
throw new Exception($id . ' is not a valid id');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public static function create($data) {
if (!is_object($data)) {
throw new Exception('data must be an object');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return true;Avoid too many return statements within this method. Open
if (strlen($ct) > strlen(gzdeflate($ct))) return false;Avoid too many return statements within this method. Open
if (strlen($decoded['iv'])>24) return false;Avoid too many return statements within this method. Open
if (base64_decode($decoded['cipher'],$strict=true)==null) { return false; }Avoid too many return statements within this method. Open
if (count(array_intersect(array_keys($decoded),$accepted_keys))!=10) { return false; }Avoid too many return statements within this method. Open
if (strlen($decoded['salt'])>14) return false;Avoid too many return statements within this method. Open
return $model;