jelhan/croodle

View on GitHub
api/classes/model.php

Summary

Maintainability
C
1 day
Test Coverage

Function save has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  public function save() {
    // create dir for data if it does not exists
    $counter = 0;
    while (true) {
      $this->set('id', $this->generateNewId());
Severity: Minor
Found in api/classes/model.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restore has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static function restore($id) {
    if (!static::isValidId($id)) {
      throw new Exception($id . ' is not a valid id');
    }

Severity: Minor
Found in api/classes/model.php - About 1 hr to fix

    Method save has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function save() {
        // create dir for data if it does not exists
        $counter = 0;
        while (true) {
          $this->set('id', $this->generateNewId());
    Severity: Minor
    Found in api/classes/model.php - About 1 hr to fix

      Function isValidSJCL has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        private static function isValidSJCL($jsonstring) {
          $accepted_keys=array('iv','v','iter','ks','ts','mode','adata','cipher','salt','ct');
      
          // Make sure content is valid json
          $decoded = json_decode($jsonstring);
      Severity: Minor
      Found in api/classes/model.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function restore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        public static function restore($id) {
          if (!static::isValidId($id)) {
            throw new Exception($id . ' is not a valid id');
          }
      
      
      Severity: Minor
      Found in api/classes/model.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        public static function create($data) {
          if (!is_object($data)) {
            throw new Exception('data must be an object');
          }
      
      
      Severity: Minor
      Found in api/classes/model.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

          if (base64_decode($decoded['cipher'],$strict=true)==null) { return false; }
      Severity: Major
      Found in api/classes/model.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            if (strlen($decoded['salt'])>14) return false;
        Severity: Major
        Found in api/classes/model.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              if (strlen($ct) > strlen(gzdeflate($ct))) return false;
          Severity: Major
          Found in api/classes/model.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return $model;
            Severity: Major
            Found in api/classes/model.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  if (count(array_intersect(array_keys($decoded),$accepted_keys))!=10) { return false; }
              Severity: Major
              Found in api/classes/model.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    if (strlen($decoded['iv'])>24) return false;
                Severity: Major
                Found in api/classes/model.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                      return true;
                  Severity: Major
                  Found in api/classes/model.php - About 30 mins to fix

                    There are no issues that match your filters.

                    Category
                    Status