jiahaog/nativefier

View on GitHub
src/playwright-test.ts

Summary

Maintainability
C
1 day
Test Coverage

File playwright-test.ts has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { once } from 'events';
import * as fs from 'fs';
import * as path from 'path';

import { Shell } from 'electron';
Severity: Minor
Found in src/playwright-test.ts - About 3 hrs to fix

    Function spawnApp has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const spawnApp = async (
        playwrightConfig: NativefierOptions = { ...DEFAULT_CONFIG },
        awaitFirstWindow = true,
        preventNavigation = false,
      ): Promise<Page | undefined> => {
    Severity: Major
    Found in src/playwright-test.ts - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const postZoomReset = await app.evaluate(
            ({ BrowserWindow }): number | undefined =>
              BrowserWindow.getFocusedWindow()?.webContents?.zoomFactor,
          );
      Severity: Minor
      Found in src/playwright-test.ts and 1 other location - About 40 mins to fix
      src/playwright-test.ts on lines 249..252

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const postZoomOut: number | undefined = await app.evaluate(
            ({ BrowserWindow }) =>
              BrowserWindow.getFocusedWindow()?.webContents?.zoomFactor,
          );
      Severity: Minor
      Found in src/playwright-test.ts and 1 other location - About 40 mins to fix
      src/playwright-test.ts on lines 241..244

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const defaultZoom: number | undefined = await app.evaluate(
            ({ BrowserWindow }) =>
              BrowserWindow.getFocusedWindow()?.webContents?.zoomFactor,
          );
      Severity: Minor
      Found in src/playwright-test.ts and 1 other location - About 40 mins to fix
      src/playwright-test.ts on lines 265..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const postZoomIn = await app.evaluate(
            ({ BrowserWindow }): number | undefined =>
              BrowserWindow.getFocusedWindow()?.webContents?.zoomFactor,
          );
      Severity: Minor
      Found in src/playwright-test.ts and 1 other location - About 40 mins to fix
      src/playwright-test.ts on lines 257..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status