Sign upLogin

jidaikobo-shibata/a11yc

View on GitHub
Star
classes/Model/Html.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function recognitionCharset has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private static function recognitionCharset($html)
    {
        $str = Element::ignoreElementsByStr($html);
        // Do not use Element\Get::elementsByRe() because crashed character cause bad cache
        preg_match_all("/\<([a-zA-Z1-6]+?) +?([^\>]*?)[\/]*?\>|\<([a-zA-Z1-6]+?)[ \/]*?\>/i", $str, $ms);
Severity: Minor
Found in classes/Model/Html.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetchHtmlFromInternet has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function fetchHtmlFromInternet($url, $ua = 'using')
    {
        $ua = $ua == 'using' ? Input::userAgent() : $ua;
        if ( ! is_string($ua)) Util::error();
        if (isset(static::$htmls[$url][$ua])) return static::$htmls[$url][$ua];
Severity: Minor
Found in classes/Model/Html.php - About 1 hr to fix

    Avoid assigning values to variables in if clauses and the like (line '124', column '9').
    Open

        private static function recognitionCharset($html)
    {
        $str = Element::ignoreElementsByStr($html);
        // Do not use Element\Get::elementsByRe() because crashed character cause bad cache
        preg_match_all("/\<([a-zA-Z1-6]+?) +?([^\>]*?)[\/]*?\>|\<([a-zA-Z1-6]+?)[ \/]*?\>/i", $str, $ms);
    Severity: Minor
    Found in classes/Model/Html.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    There are no issues that match your filters.

    Category
    Status