Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/RestoCollection.php

Summary

Maintainability
C
1 day
Test Coverage

Method toArray has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toArray()
    {

        $osDescription = $this->osDescription[$this->context->lang] ?? $this->osDescription['en'];
Severity: Major
Found in app/resto/core/RestoCollection.php - About 2 hrs to fix

    File RestoCollection.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
    Severity: Minor
    Found in app/resto/core/RestoCollection.php - About 2 hrs to fix

      Function toArray has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toArray()
    {

        $osDescription = $this->osDescription[$this->context->lang] ?? $this->osDescription['en'];
      Severity: Minor
      Found in app/resto/core/RestoCollection.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadFromJSON has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function loadFromJSON($object, $modelName = null)
    {
        /*
         * Check that object is a valid array
         */
      Severity: Minor
      Found in app/resto/core/RestoCollection.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function load($object = null, $modelName = null)
    {

        if (isset($object)) {
            return $this->loadFromJSON($object, $modelName);
      Severity: Minor
      Found in app/resto/core/RestoCollection.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status