Sign upLogin

jjrom/resto

View on GitHub
Star

Showing 247 of 247 total issues

File RestoModel.php has 624 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Major
Found in app/resto/core/RestoModel.php - About 1 day to fix

    File FeaturesFunctions.php has 553 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
    Severity: Major
    Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 1 day to fix

      Function filterSummaries has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
      Open

          private function filterSummaries($summaries, $types)
    {
        $filteredSummaries = array();
        
        foreach (array_values($summaries) as $summary) {
      Severity: Minor
      Found in app/resto/core/RestoCollections.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setParameters has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setParameters($format)
    {
        foreach ($this->model->searchFilters as $filterName => $filter) {
            if (isset($filter) && $filterName != 'searchTerms' && !isset($filter['hidden'])) {
                $this->startElement('parameters:Parameter');
      Severity: Minor
      Found in app/resto/core/xml/OSDD.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File STAC.php has 429 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/*
 * Copyright 2022 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
      Severity: Minor
      Found in app/resto/core/addons/STAC.php - About 6 hrs to fix

        Function getFacetsCount has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getFacetsCount($minMatch)
    {
        $facets = array(
            'count' => 0,
            'catalogs' => array(),
        Severity: Minor
        Found in app/resto/core/utils/STACUtil.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepareFilters has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
        Open

            public function prepareFilters($paramsWithOperation, $sortKey)
    {
        $filters = array();
        $sortFilters = array();
        Severity: Minor
        Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSummaries has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getSummaries($types, $collectionId)
    {
        
        $summaries = array();
        Severity: Minor
        Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File FiltersFunctions.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
        Severity: Minor
        Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 5 hrs to fix

          Function featureArrayToKeysValues has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
          Open

              private function featureArrayToKeysValues($collection, $featureArray, $protected, $updatabled)
    {
        // Initialize
        $keysAndValues = array(
            'links' => isset($featureArray['links']) ? json_encode($featureArray['links'], JSON_UNESCAPED_SLASHES) : null,
          Severity: Minor
          Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method formatRawFeatureArray has 128 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function formatRawFeatureArray($rawFeatureArray, $collection)
    {
        $self = $this->context->core['baseUrl'] . RestoUtil::replaceInTemplate(RestoRouter::ROUTE_TO_FEATURE, array(
            'collectionId' => $collection->id,
            'featureId' => $rawFeatureArray['id']
          Severity: Major
          Found in app/resto/core/utils/RestoFeatureUtil.php - About 5 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                if ($insert['result'] !== false) {
                        $featuresInserted[] = array(
                            'featureId' => $insert['result']['id'],
                            'productIdentifier' => $insert['result']['productIdentifier'],
                            'facetsStored' => $insert['result']['facetsStored']
            Severity: Major
            Found in app/resto/core/RestoModel.php and 1 other location - About 4 hrs to fix
            app/resto/core/RestoModel.php on lines 447..456

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ($insert['result'] !== false) {
                $featuresInserted[] = array(
                    'featureId' => $insert['result']['id'],
                    'productIdentifier' => $insert['result']['productIdentifier'],
                    'facetsStored' => $insert['result']['facetsStored']
            Severity: Major
            Found in app/resto/core/RestoModel.php and 1 other location - About 4 hrs to fix
            app/resto/core/RestoModel.php on lines 464..473

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getRootCatalogLinks has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getRootCatalogLinks($minMatch)
    {
        $links = array();

        /*
            Severity: Minor
            Found in app/resto/core/utils/STACUtil.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function extractToponym has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                private function extractToponym($params, &$details, &$hashToDiscard)
    {
        $foundLocation = null;

        /*
            Severity: Minor
            Found in app/resto/core/RestoQueryAnalyzer.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File CollectionsFunctions.php has 356 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
            Severity: Minor
            Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 4 hrs to fix

              Function setCatalogsLinksFromFacet has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setCatalogsLinksFromFacet($params)
    {
        $nbOfSegments = count($this->segments);
        $leafValue = $this->segments[$nbOfSegments - 1];
              Severity: Minor
              Found in app/resto/core/addons/STAC.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function formatRawFeatureArray has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function formatRawFeatureArray($rawFeatureArray, $collection)
    {
        $self = $this->context->core['baseUrl'] . RestoUtil::replaceInTemplate(RestoRouter::ROUTE_TO_FEATURE, array(
            'collectionId' => $collection->id,
            'featureId' => $rawFeatureArray['id']
              Severity: Minor
              Found in app/resto/core/utils/RestoFeatureUtil.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 107 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct($options = array())
    {
        parent::__construct($options);
        
        /*
              Severity: Major
              Found in app/resto/core/models/SatelliteModel.php - About 4 hrs to fix

                File RestoFeatureCollection.php has 340 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
                Severity: Minor
                Found in app/resto/core/RestoFeatureCollection.php - About 4 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language