Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/RestoFeatureCollection.php

Summary

Maintainability
C
1 day
Test Coverage

File RestoFeatureCollection.php has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Minor
Found in app/resto/core/RestoFeatureCollection.php - About 4 hrs to fix

    Method getLinks has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getLinks($sorting, $collectionId)
    {
        /*
         * Base links are always returned
         */
    Severity: Minor
    Found in app/resto/core/RestoFeatureCollection.php - About 1 hr to fix

      Function writeRequestParams has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          private function writeRequestParams($params)
    {
        $arr = array();

        foreach ($params as $key => $value) {
      Severity: Minor
      Found in app/resto/core/RestoFeatureCollection.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getPaging has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getPaging($count, $limit, $offset)
    {
        $count['returned'] = count($this->restoFeatures);

        /*
      Severity: Minor
      Found in app/resto/core/RestoFeatureCollection.php - About 1 hr to fix

        Function getLinks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getLinks($sorting, $collectionId)
    {
        /*
         * Base links are always returned
         */
        Severity: Minor
        Found in app/resto/core/RestoFeatureCollection.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method load has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function load($collection)
    {
        /*
         * Request start time
         */
        Severity: Minor
        Found in app/resto/core/RestoFeatureCollection.php - About 1 hr to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct($context, $user, $collections, $model, $query)
          Severity: Minor
          Found in app/resto/core/RestoFeatureCollection.php - About 35 mins to fix

            Function cleanFilters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function cleanFilters($searchFilters)
    {
        $query = array();
        $exclude = array(
            'count',
            Severity: Minor
            Found in app/resto/core/RestoFeatureCollection.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getPaging has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getPaging($count, $limit, $offset)
    {
        $count['returned'] = count($this->restoFeatures);

        /*
            Severity: Minor
            Found in app/resto/core/RestoFeatureCollection.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status