Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/RestoModel.php

Summary

Maintainability
F
4 days
Test Coverage

File RestoModel.php has 624 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Major
Found in app/resto/core/RestoModel.php - About 1 day to fix

    RestoModel has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class RestoModel
{
    /*
     * Model options
     */
    Severity: Minor
    Found in app/resto/core/RestoModel.php - About 2 hrs to fix

      Function storeFeatures has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function storeFeatures($collection, $body, $params)
    {
        // Convert input to resto model
        $data = $this->inputToResto($body, $collection, $params);
      Severity: Minor
      Found in app/resto/core/RestoModel.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method storeFeatures has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function storeFeatures($collection, $body, $params)
    {
        // Convert input to resto model
        $data = $this->inputToResto($body, $collection, $params);
      Severity: Major
      Found in app/resto/core/RestoModel.php - About 2 hrs to fix

        Method explodeSearchTerms has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function explodeSearchTerms($obj)
    {
        $hashtags = [];
        $output = [];
        Severity: Minor
        Found in app/resto/core/RestoModel.php - About 1 hr to fix

          Method prepareFeatureArray has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function prepareFeatureArray($collection, $data, $params = array())
    {
        /*
         * Assume input file or stream is a JSON Feature
         */
          Severity: Minor
          Found in app/resto/core/RestoModel.php - About 1 hr to fix

            Function getITagParams has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getITagParams($collection)
    {
        // iTag is not use because model strategy is 'none' or explicitely _useItag is set to false
        if ((isset($collection->context->query['_useItag']) && filter_var($collection->context->query['_useItag'], FILTER_VALIDATE_BOOLEAN) === false) || ($collection->model->tagConfig['strategy'] === 'none')) {
            return null;
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function explodeSearchTerms has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function explodeSearchTerms($obj)
    {
        $hashtags = [];
        $output = [];
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function prepareFeatureArray has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private function prepareFeatureArray($collection, $data, $params = array())
    {
        /*
         * Assume input file or stream is a JSON Feature
         */
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function remapInputProperties has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function remapInputProperties($properties)
    {
        if (empty($this->inputMapping)) {
            return $properties;
        }
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function remap has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function remap($featureArray, $collection)
    {
        /*
         * These properties are discarded from output
         */
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function toOSKeys has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function toOSKeys($filterNames, $processSearchTerms = false)
    {
        $arr = array();
        foreach ($filterNames as $key => $obj) {
            if (isset($this->searchFilters[$key])) {
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateFilterString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function validateFilterString($filterKey, $value)
    {
        /*
         * If operation = "in" then value is a comma separated list - check pattern for each element of the list
         */
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFiltersFromQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFiltersFromQuery($query)
    {
        $params = array();
        $unknowns = array();
        foreach ($query as $key => $value) {
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getQueryables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getQueryables()
    {
        $queryables = array();
        foreach (array_keys($this->searchFilters) as $filterKey) {
            if (isset($this->searchFilters[$filterKey]['queryable'])) {
            Severity: Minor
            Found in app/resto/core/RestoModel.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                if ($insert['result'] !== false) {
                        $featuresInserted[] = array(
                            'featureId' => $insert['result']['id'],
                            'productIdentifier' => $insert['result']['productIdentifier'],
                            'facetsStored' => $insert['result']['facetsStored']
            Severity: Major
            Found in app/resto/core/RestoModel.php and 1 other location - About 4 hrs to fix
            app/resto/core/RestoModel.php on lines 447..456

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ($insert['result'] !== false) {
                $featuresInserted[] = array(
                    'featureId' => $insert['result']['id'],
                    'productIdentifier' => $insert['result']['productIdentifier'],
                    'facetsStored' => $insert['result']['facetsStored']
            Severity: Major
            Found in app/resto/core/RestoModel.php and 1 other location - About 4 hrs to fix
            app/resto/core/RestoModel.php on lines 464..473

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 181.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status