Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/RestoNotifier.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function sendMail has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function sendMail($params, $smtp = array())
    {
        if (! isset($params) || ! is_array($params)) {
            return false;
        }
Severity: Minor
Found in app/resto/core/RestoNotifier.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sendMail has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendMail($params, $smtp = array())
    {
        if (! isset($params) || ! is_array($params)) {
            return false;
        }
Severity: Minor
Found in app/resto/core/RestoNotifier.php - About 1 hr to fix

    Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($servicesInfos, $lang)
    {
        foreach (array_keys($servicesInfos) as $key) {
            // Translation
            if (isset($servicesInfos[$key]['message'])) {
    Severity: Minor
    Found in app/resto/core/RestoNotifier.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in app/resto/core/RestoNotifier.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status