Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/dbfunctions/CollectionsFunctions.php

Summary

Maintainability
D
1 day
Test Coverage

File CollectionsFunctions.php has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Minor
Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 4 hrs to fix

    Method storeCollectionDescription has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function storeCollectionDescription($collection)
    {
        /*
         * First generate a right keywords array
         */
    Severity: Major
    Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 2 hrs to fix

      Method format has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function format($rawDescription, $osDescription)
    {
        $collection = array(
            'id' => $rawDescription['id'],
            'aliases' => $rawDescription['aliases'] ?? null,
      Severity: Minor
      Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 1 hr to fix

        Method storeOSDescription has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function storeOSDescription($collection)
    {
        /*
         * Insert OpenSearch descriptions within osdescriptions table
         * (one description per lang)
        Severity: Minor
        Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 1 hr to fix

          Function storeCollectionDescription has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function storeCollectionDescription($collection)
    {
        /*
         * First generate a right keywords array
         */
          Severity: Minor
          Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getTimeExtent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getTimeExtent($dates)
    {
        if (count($dates) === 0 || !isset($dates[0])) {
            return array(
                'startDate' => null,
          Severity: Minor
          Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function storeOSDescription has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function storeOSDescription($collection)
    {
        /*
         * Insert OpenSearch descriptions within osdescriptions table
         * (one description per lang)
          Severity: Minor
          Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateExtent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updateExtent($collection, $extentArrays)
    {
        if (! isset($extentArrays)) {
            return false;
        }
          Severity: Minor
          Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 1 hr to fix

            Function updateExtent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function updateExtent($collection, $extentArrays)
    {
        if (! isset($extentArrays)) {
            return false;
        }
            Severity: Minor
            Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status