Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/dbfunctions/FacetsFunctions.php

Summary

Maintainability
D
1 day
Test Coverage

Function getSummaries has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public function getSummaries($types, $collectionId)
    {
        
        $summaries = array();
Severity: Minor
Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getSummaries has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getSummaries($types, $collectionId)
    {
        
        $summaries = array();
Severity: Major
Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 3 hrs to fix

    File FacetsFunctions.php has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
    Severity: Minor
    Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 2 hrs to fix

      Function getFacetsFromKeywords has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFacetsFromKeywords($keywords, $facetCategories, $collectionId, $options = array())
    {
        /*
         * One facet per keyword
         */
      Severity: Minor
      Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateFacet has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateFacet($facet)
    {
        
        $values = array(
            $facet['id']
      Severity: Minor
      Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 1 hr to fix

        Method storeFacets has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function storeFacets($facets, $userid, $collectionId = '*')
    {
        // Empty facets - do nothing
        if (!isset($facets) || count($facets) === 0) {
            return;
        Severity: Minor
        Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 1 hr to fix

          Function getFacetCategory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getFacetCategory($facetCategories, $type)
    {
        if (! isset($type)) {
            return null;
        }
          Severity: Minor
          Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status