Sign upLogin

jjrom/resto

View on GitHub
Star
app/resto/core/dbfunctions/FiltersFunctions.php

Summary

Maintainability
F
3 days
Test Coverage

Function prepareFilters has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function prepareFilters($paramsWithOperation, $sortKey)
    {
        $filters = array();
        $sortFilters = array();
Severity: Minor
Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File FiltersFunctions.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Minor
Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 5 hrs to fix

    FiltersFunctions has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class FiltersFunctions
{
    /*
     * Non search filters are excluded from search
     */
    Severity: Minor
    Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 2 hrs to fix

      Method prepareFilters has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function prepareFilters($paramsWithOperation, $sortKey)
    {
        $filters = array();
        $sortFilters = array();
      Severity: Major
      Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 2 hrs to fix

        Method prepareFilterQuery has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function prepareFilterQuery($paramsWithOperation, $filterName)
    {
        $featureTableName = $this->tablePrefix . 'feature';
        $exclusion = isset($paramsWithOperation[$filterName]['not']) && $paramsWithOperation[$filterName]['not'] ? true : false;
        Severity: Minor
        Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 1 hr to fix

          Function cql2FiltersToSQL has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private function cql2FiltersToSQL($cql2Filters, $operator)
    {
        $filters = array();
        $paramsWithOperation = array();
          Severity: Minor
          Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function prepareORFilters has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function prepareORFilters($filterName, $filterValue, $exclusion)
    {
        /*
         * Set quote to "'" for non numeric filter types
         */
          Severity: Minor
          Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getWhereClause has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getWhereClause($filtersAndJoins, $options = array())
    {
        $size = count($filtersAndJoins['filters']);

        if ($size > 0) {
          Severity: Minor
          Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method processSearchTerms has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function processSearchTerms($searchTerm, &$filters, $featureTableName, $filterName, $exclusion)
          Severity: Minor
          Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 35 mins to fix

            Function processSearchTerms has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function processSearchTerms($searchTerm, &$filters, $featureTableName, $filterName, $exclusion)
    {
        /*
         * The '|' character is understood as "OR"
         * For performance reason it is better to use && operator instead of multiple @> with OR
            Severity: Minor
            Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            return array(
                    'value' => count($ors) > 1 ? '(' . join(' OR ', $ors) . ')' : $ors[0],
                    'isGeo' => false
                );
            Severity: Major
            Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->prepareFilterQueryIntersects($filterName, $paramsWithOperation[$filterName], $exclusion);
              Severity: Major
              Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->prepareFilterQueryDistance($filterName, $paramsWithOperation, $exclusion);
                Severity: Major
                Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return array(
                    'value' => $this->addNot($exclusion) . QueryUtil::intervalToQuery($this->context->dbDriver->getConnection(), $paramsWithOperation[$filterName]['value'], $this->getTableName($filterName) . '.' . $this->model->searchFilters[$filterName]['key']),
                    'isGeo' => false
                );
                  Severity: Major
                  Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 30 mins to fix

                    Function prepareFilterQueryKeywords has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function prepareFilterQueryKeywords($featureTableName, $filterName, $searchTerms, $exclusion)
    {
        $terms = array();
        $filters = array(
            'with' => array(),
                    Severity: Minor
                    Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                $filter = $start . pg_escape_string($this->context->dbDriver->getConnection(), 'POLYGON((' . $coords[0] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[1] . '))') . $end;
                    Severity: Major
                    Found in app/resto/core/dbfunctions/FiltersFunctions.php and 1 other location - About 2 hrs to fix
                    app/resto/core/dbfunctions/FiltersFunctions.php on lines 403..403

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 121.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                'wkt' => isset($coords) ? 'POLYGON((' . $coords[0] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[1] . '))' : $filterValue['value'],
                    Severity: Major
                    Found in app/resto/core/dbfunctions/FiltersFunctions.php and 1 other location - About 2 hrs to fix
                    app/resto/core/dbfunctions/FiltersFunctions.php on lines 481..481

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 121.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status