Showing 239 of 247 total issues

File RestoModel.php has 624 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Major
Found in app/resto/core/RestoModel.php - About 1 day to fix

    File FeaturesFunctions.php has 553 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*
     * Copyright 2018 Jérôme Gasperi
     *
     * Licensed under the Apache License, version 2.0 (the "License");
    Severity: Major
    Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 1 day to fix

      Function filterSummaries has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
      Open

          private function filterSummaries($summaries, $types)
          {
              $filteredSummaries = array();
              
              foreach (array_values($summaries) as $summary) {
      Severity: Minor
      Found in app/resto/core/RestoCollections.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setParameters has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setParameters($format)
          {
              foreach ($this->model->searchFilters as $filterName => $filter) {
                  if (isset($filter) && $filterName != 'searchTerms' && !isset($filter['hidden'])) {
                      $this->startElement('parameters:Parameter');
      Severity: Minor
      Found in app/resto/core/xml/OSDD.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File STAC.php has 429 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /*
       * Copyright 2022 Jérôme Gasperi
       *
       * Licensed under the Apache License, version 2.0 (the "License");
      Severity: Minor
      Found in app/resto/core/addons/STAC.php - About 6 hrs to fix

        Function getFacetsCount has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getFacetsCount($minMatch)
            {
                $facets = array(
                    'count' => 0,
                    'catalogs' => array(),
        Severity: Minor
        Found in app/resto/core/utils/STACUtil.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepareFilters has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
        Open

            public function prepareFilters($paramsWithOperation, $sortKey)
            {
                $filters = array();
                $sortFilters = array();
        
        
        Severity: Minor
        Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSummaries has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getSummaries($types, $collectionId)
            {
                
                $summaries = array();
        
        
        Severity: Minor
        Found in app/resto/core/dbfunctions/FacetsFunctions.php - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File FiltersFunctions.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /*
         * Copyright 2018 Jérôme Gasperi
         *
         * Licensed under the Apache License, version 2.0 (the "License");
        Severity: Minor
        Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 5 hrs to fix

          Function featureArrayToKeysValues has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
          Open

              private function featureArrayToKeysValues($collection, $featureArray, $protected, $updatabled)
              {
                  // Initialize
                  $keysAndValues = array(
                      'links' => isset($featureArray['links']) ? json_encode($featureArray['links'], JSON_UNESCAPED_SLASHES) : null,
          Severity: Minor
          Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method formatRawFeatureArray has 128 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function formatRawFeatureArray($rawFeatureArray, $collection)
              {
                  $self = $this->context->core['baseUrl'] . RestoUtil::replaceInTemplate(RestoRouter::ROUTE_TO_FEATURE, array(
                      'collectionId' => $collection->id,
                      'featureId' => $rawFeatureArray['id']
          Severity: Major
          Found in app/resto/core/utils/RestoFeatureUtil.php - About 5 hrs to fix

            Function getRootCatalogLinks has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getRootCatalogLinks($minMatch)
                {
                    $links = array();
            
                    /*
            Severity: Minor
            Found in app/resto/core/utils/STACUtil.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function extractToponym has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                private function extractToponym($params, &$details, &$hashToDiscard)
                {
                    $foundLocation = null;
            
                    /*
            Severity: Minor
            Found in app/resto/core/RestoQueryAnalyzer.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File CollectionsFunctions.php has 356 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            /*
             * Copyright 2018 Jérôme Gasperi
             *
             * Licensed under the Apache License, version 2.0 (the "License");
            Severity: Minor
            Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 4 hrs to fix

              Function setCatalogsLinksFromFacet has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function setCatalogsLinksFromFacet($params)
                  {
                      $nbOfSegments = count($this->segments);
                      $leafValue = $this->segments[$nbOfSegments - 1];
                      
              Severity: Minor
              Found in app/resto/core/addons/STAC.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function formatRawFeatureArray has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function formatRawFeatureArray($rawFeatureArray, $collection)
                  {
                      $self = $this->context->core['baseUrl'] . RestoUtil::replaceInTemplate(RestoRouter::ROUTE_TO_FEATURE, array(
                          'collectionId' => $collection->id,
                          'featureId' => $rawFeatureArray['id']
              Severity: Minor
              Found in app/resto/core/utils/RestoFeatureUtil.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 107 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct($options = array())
                  {
                      parent::__construct($options);
                      
                      /*
              Severity: Major
              Found in app/resto/core/models/SatelliteModel.php - About 4 hrs to fix

                File RestoFeatureCollection.php has 340 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /*
                 * Copyright 2018 Jérôme Gasperi
                 *
                 * Licensed under the Apache License, version 2.0 (the "License");
                Severity: Minor
                Found in app/resto/core/RestoFeatureCollection.php - About 4 hrs to fix

                  File UsersFunctions.php has 334 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /*
                   * Copyright 2018 Jérôme Gasperi
                   *
                  Severity: Minor
                  Found in app/resto/core/dbfunctions/UsersFunctions.php - About 4 hrs to fix

                    Function process has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function process($method, $path, $query)
                        {
                    
                            // Special case for doc generation
                            if ( $path === '/_routes' ) {
                    Severity: Minor
                    Found in app/resto/core/RestoRouter.php - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language