Showing 240 of 248 total issues

File Tag.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Minor
Found in app/resto/core/addons/Tag.php - About 2 hrs to fix

    Method analyze has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function analyze($params, $model)
        {
            /*
             * Store original params
             */
    Severity: Major
    Found in app/resto/core/RestoQueryAnalyzer.php - About 2 hrs to fix

      Method storeCollectionDescription has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function storeCollectionDescription($collection)
          {
              /*
               * First generate a right keywords array
               */
      Severity: Major
      Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 2 hrs to fix

        FiltersFunctions has 21 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class FiltersFunctions
        {
            /*
             * Non search filters are excluded from search
             */
        Severity: Minor
        Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 2 hrs to fix

          Method toArray has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toArray()
              {
                  $collections = array(
                      'stac_version' => STAC::STAC_VERSION,
                      'id' => $this->context->osDescription['ShortName'],
          Severity: Major
          Found in app/resto/core/RestoCollections.php - About 2 hrs to fix

            Method formatUserProfile has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function formatUserProfile($rawProfile)
                {
                    // Empty profile
                    $profile = array();
            
            
            Severity: Major
            Found in app/resto/core/dbfunctions/UsersFunctions.php - About 2 hrs to fix

              Function storeFeatures has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function storeFeatures($collection, $body, $params)
                  {
                      // Convert input to resto model
                      $data = $this->inputToResto($body, $collection, $params);
              
              
              Severity: Minor
              Found in app/resto/core/RestoModel.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function updateUserProfile has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function updateUserProfile($profile, $storageInfo)
                  {
                      if (!is_array($profile) || !isset($profile['email'])) {
                          RestoLogUtil::httpError(400);
                      }
              Severity: Minor
              Found in app/resto/core/dbfunctions/UsersFunctions.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function sendMail has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function sendMail($params, $smtp = array())
                  {
                      if (! isset($params) || ! is_array($params)) {
                          return false;
                      }
              Severity: Minor
              Found in app/resto/core/RestoNotifier.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method storeFeatures has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function storeFeatures($collection, $body, $params)
                  {
                      // Convert input to resto model
                      $data = $this->inputToResto($body, $collection, $params);
              
              
              Severity: Major
              Found in app/resto/core/RestoModel.php - About 2 hrs to fix

                Method updateFeature has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function updateFeature($feature, $collection, $newFeatureArray)
                    {
                        if (!isset($feature)) {
                            RestoLogUtil::httpError(404);
                        }
                Severity: Major
                Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 2 hrs to fix

                  Method prepareFilters has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function prepareFilters($paramsWithOperation, $sortKey)
                      {
                          $filters = array();
                          $sortFilters = array();
                  
                  
                  Severity: Major
                  Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 2 hrs to fix

                    Method storeFeature has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function storeFeature($id, $collection, $featureArray)
                        {
                            $keysValues = $this->featureArrayToKeysValues(
                                $collection,
                                $featureArray,
                    Severity: Minor
                    Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 2 hrs to fix

                      Method setParameters has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function setParameters($format)
                          {
                              foreach ($this->model->searchFilters as $filterName => $filter) {
                                  if (isset($filter) && $filterName != 'searchTerms' && !isset($filter['hidden'])) {
                                      $this->startElement('parameters:Parameter');
                      Severity: Minor
                      Found in app/resto/core/xml/OSDD.php - About 1 hr to fix

                        Method getLinks has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private function getLinks($sorting, $collectionId)
                            {
                                /*
                                 * Base links are always returned
                                 */
                        Severity: Minor
                        Found in app/resto/core/RestoFeatureCollection.php - About 1 hr to fix

                          Function setOutputFormat has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private function setOutputFormat()
                              {
                                  $this->outputFormat = $this->getPathSuffix();
                                  
                                  /*
                          Severity: Minor
                          Found in app/resto/core/RestoContext.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function toArray has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function toArray()
                              {
                          
                                  $osDescription = $this->osDescription[$this->context->lang] ?? $this->osDescription['en'];
                          
                          
                          Severity: Minor
                          Found in app/resto/core/RestoCollection.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function formatPartialUserProfile has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function formatPartialUserProfile($rawProfile)
                              {
                                  
                                  $profile = array(
                                      'id' => $rawProfile['id'],
                          Severity: Minor
                          Found in app/resto/core/dbfunctions/UsersFunctions.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method extractToponym has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function extractToponym($params, &$details, &$hashToDiscard)
                              {
                                  $foundLocation = null;
                          
                                  /*
                          Severity: Minor
                          Found in app/resto/core/RestoQueryAnalyzer.php - About 1 hr to fix

                            Method getType has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function getType(&$value)
                                {
                                    $type = self::T_NONE;
                            
                                    switch (true) {
                            Severity: Minor
                            Found in app/resto/core/utils/Lexer.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language