Sign upLogin

jjsoft-ar/siges-core

View on GitHub
Star

Showing 72 of 72 total issues

Avoid unused parameters such as '$fractal'.
Open

        return $this->response->item($field, new FieldTransformer(), [], function ($resource, $fractal) use ($data) {
Severity: Minor
Found in src/Http/Controllers/Core/FieldsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$command'.
Open

    public function preAssignEvent($command)
Severity: Minor
Found in src/Field/FieldTypeImplementationTrait.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$id'.
Open

    public function destroy($id, $fields)
Severity: Minor
Found in src/Http/Controllers/Core/FieldsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused local variables such as '$key'.
Open

        foreach ($classValidationRules as $key => $rule) {
Severity: Minor
Found in src/Entries/Middleware/ValidateEntryData.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$route'.
Open

    public function authenticate(Request $request, Route $route)
Severity: Minor
Found in src/Auth/AppAuthenticationProvider.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$fractal'.
Open

        return $this->response->item($field, new FieldTransformer(), [], function ($resource, $fractal) use ($data) {
Severity: Minor
Found in src/Http/Controllers/Core/FieldsController.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method execute uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $command = $this->setOrder($command);
        }
Severity: Minor
Found in src/FieldGenerator/Middleware/FieldOrderSetter.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The variable $create_field is not named in camelCase.
Open

    public function __construct(
        $entity_id = "",
        $namespace = "",
        $name = "",
        $description = "",
Severity: Minor
Found in src/FieldGenerator/CreateFieldCommand.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $entry_id is not named in camelCase.
Open

    public function __construct(EntityModel $entity, $entry_id, $data)
    {
        $this->entity = $entity;
        $this->entry_id = $entry_id;
        $this->data = $data;
Severity: Minor
Found in src/Entries/Events/EntryWasUpdated.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $entry_id is not named in camelCase.
Open

    public function __construct($entity, $entry_id, array $input)
    {
        $this->entity = $entity;
        $this->entry_id = $entry_id;
        $this->input = $input;
Severity: Minor
Found in src/Entries/UpdateEntryCommand.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $create_table is not named in camelCase.
Open

    public function __construct($namespace = "", $name = "", $description = "", $slug = "", $prefix = "", $locked = true, $create_table = true)
    {
        $this->namespace = $namespace;
        $this->name = $name;
        $this->description = $description;
Severity: Minor
Found in src/EntityGenerator/EntityGeneratorCommand.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $entity_id is not named in camelCase.
Open

    public function __construct(
        $entity_id = "",
        $namespace = "",
        $name = "",
        $description = "",
Severity: Minor
Found in src/FieldGenerator/CreateFieldCommand.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language