Sign upLogin

jkawamoto/loci

View on GitHub
Star

Showing 61 of 61 total issues

Function TestPythonOverwriteEvnSet has 67 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestPythonOverwriteEvnSet(t *testing.T) {

    var err error
    // The following configuration is copied from matplotlib.
    travis, err := NewTravis([]byte(`language: "python"
Severity: Minor
Found in command/travis_python_test.go - About 1 hr to fix

    Method Travis.argumentSetPython has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func (t *Travis) argumentSetPython(logger io.Writer) (res TestCaseSet, err error) {

    res = make(TestCaseSet)
    global := parseEnv(strings.Join(t.Env.Global, " "))
    Severity: Minor
    Found in command/travis_python.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Travis.argumentSetGo has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
    Open

    func (t *Travis) argumentSetGo() (res TestCaseSet, err error) {

    res = make(TestCaseSet)
    global := parseEnv(strings.Join(t.Env.Global, " "))
    Severity: Minor
    Found in command/travis_go.go - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Archive has 9 return statements (exceeds 4 allowed).
    Open

    func Archive(ctx context.Context, dir string, filename string) (err error) {

    writeFile, err := os.OpenFile(filename, os.O_WRONLY|os.O_CREATE, 0600)
    if err != nil {
        return
    Severity: Major
    Found in command/archive.go - About 55 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, version := range t.Python {

        if len(t.Env.Matrix) == 0 {
            // If there is no matrix configuration, use only global configuration.
            res[version] = append(res[version], global)
      Severity: Minor
      Found in command/travis_python.go and 1 other location - About 45 mins to fix
      command/travis_go.go on lines 38..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, version := range t.Go {

        if len(t.Env.Matrix) == 0 {
            // If there is no matrix configuration, use only global configuration.
            res[version] = append(res[version], global)
      Severity: Minor
      Found in command/travis_go.go and 1 other location - About 45 mins to fix
      command/travis_python.go on lines 54..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function Start has 7 return statements (exceeds 4 allowed).
      Open

      func Start(ctx context.Context, tag, name string, env []string, output io.Writer) (err error) {

    // Create a docker client.
    cli, err := client.NewEnvClient()
    if err != nil {
      Severity: Major
      Found in command/docker.go - About 45 mins to fix

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        func TestParseBeforeScriptWithString(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
before_script: python setup.py test`))
    if err != nil {
        t.Fatal(err.Error())
        Severity: Major
        Found in command/travis_test.go and 7 other locations - About 45 mins to fix
        command/travis_test.go on lines 133..142
        command/travis_test.go on lines 144..154
        command/travis_test.go on lines 166..175
        command/travis_test.go on lines 177..188
        command/travis_test.go on lines 211..221
        command/travis_test.go on lines 233..242
        command/travis_test.go on lines 244..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 115.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        func TestParseBeforeScriptWithList(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
before_script:
  - python setup.py test`))
    if err != nil {
        Severity: Major
        Found in command/travis_test.go and 7 other locations - About 45 mins to fix
        command/travis_test.go on lines 133..142
        command/travis_test.go on lines 144..154
        command/travis_test.go on lines 166..175
        command/travis_test.go on lines 177..188
        command/travis_test.go on lines 200..209
        command/travis_test.go on lines 233..242
        command/travis_test.go on lines 244..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 115.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function TestArchive has 7 return statements (exceeds 4 allowed).
        Open

        func TestArchive(t *testing.T) {

    temp := os.TempDir()
    target := path.Join(temp, "test.tar.gz")
    t.Logf("Creating an archive file: %s", target)
        Severity: Major
        Found in command/archive_test.go - About 45 mins to fix

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

          func TestParseBeforeInstallWithString(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
before_install: install 1`))
    if err != nil {
        t.Fatal(err.Error())
          Severity: Major
          Found in command/travis_test.go and 7 other locations - About 45 mins to fix
          command/travis_test.go on lines 144..154
          command/travis_test.go on lines 166..175
          command/travis_test.go on lines 177..188
          command/travis_test.go on lines 200..209
          command/travis_test.go on lines 211..221
          command/travis_test.go on lines 233..242
          command/travis_test.go on lines 244..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

          func TestParseBeforeInstallWithList(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
before_install:
  - install 1`))
    if err != nil {
          Severity: Major
          Found in command/travis_test.go and 7 other locations - About 45 mins to fix
          command/travis_test.go on lines 133..142
          command/travis_test.go on lines 166..175
          command/travis_test.go on lines 177..188
          command/travis_test.go on lines 200..209
          command/travis_test.go on lines 211..221
          command/travis_test.go on lines 233..242
          command/travis_test.go on lines 244..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

          func TestParseScriptWithString(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
script: python setup.py test`))
    if err != nil {
        t.Fatal(err.Error())
          Severity: Major
          Found in command/travis_test.go and 7 other locations - About 45 mins to fix
          command/travis_test.go on lines 133..142
          command/travis_test.go on lines 144..154
          command/travis_test.go on lines 166..175
          command/travis_test.go on lines 177..188
          command/travis_test.go on lines 200..209
          command/travis_test.go on lines 211..221
          command/travis_test.go on lines 244..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

          func TestParseInstallWithString(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
install: install 1`))
    if err != nil {
        t.Fatal(err.Error())
          Severity: Major
          Found in command/travis_test.go and 7 other locations - About 45 mins to fix
          command/travis_test.go on lines 133..142
          command/travis_test.go on lines 144..154
          command/travis_test.go on lines 177..188
          command/travis_test.go on lines 200..209
          command/travis_test.go on lines 211..221
          command/travis_test.go on lines 233..242
          command/travis_test.go on lines 244..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

          func TestParseScriptWithList(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
script:
  - python setup.py test`))
    if err != nil {
          Severity: Major
          Found in command/travis_test.go and 7 other locations - About 45 mins to fix
          command/travis_test.go on lines 133..142
          command/travis_test.go on lines 144..154
          command/travis_test.go on lines 166..175
          command/travis_test.go on lines 177..188
          command/travis_test.go on lines 200..209
          command/travis_test.go on lines 211..221
          command/travis_test.go on lines 233..242

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

          func TestParseInstallWithList(t *testing.T) {
    travis, err := NewTravis([]byte(`language: ""
install:
  - install 1`))
          Severity: Major
          Found in command/travis_test.go and 7 other locations - About 45 mins to fix
          command/travis_test.go on lines 133..142
          command/travis_test.go on lines 144..154
          command/travis_test.go on lines 166..175
          command/travis_test.go on lines 200..209
          command/travis_test.go on lines 211..221
          command/travis_test.go on lines 233..242
          command/travis_test.go on lines 244..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func assetsDockerfilePython() (*asset, error) {
    bytes, err := assetsDockerfilePythonBytes()
    if err != nil {
        return nil, err
    }
          Severity: Major
          Found in command/assets.go and 5 other locations - About 40 mins to fix
          command/assets.go on lines 85..94
          command/assets.go on lines 105..114
          command/assets.go on lines 145..154
          command/assets.go on lines 165..174
          command/assets.go on lines 185..194

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func assetsDockerfile() (*asset, error) {
    bytes, err := assetsDockerfileBytes()
    if err != nil {
        return nil, err
    }
          Severity: Major
          Found in command/assets.go and 5 other locations - About 40 mins to fix
          command/assets.go on lines 105..114
          command/assets.go on lines 125..134
          command/assets.go on lines 145..154
          command/assets.go on lines 165..174
          command/assets.go on lines 185..194

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func assetsEntrypointPython() (*asset, error) {
    bytes, err := assetsEntrypointPythonBytes()
    if err != nil {
        return nil, err
    }
          Severity: Major
          Found in command/assets.go and 5 other locations - About 40 mins to fix
          command/assets.go on lines 85..94
          command/assets.go on lines 105..114
          command/assets.go on lines 125..134
          command/assets.go on lines 145..154
          command/assets.go on lines 165..174

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func assetsEntrypoint() (*asset, error) {
    bytes, err := assetsEntrypointBytes()
    if err != nil {
        return nil, err
    }
          Severity: Major
          Found in command/assets.go and 5 other locations - About 40 mins to fix
          command/assets.go on lines 85..94
          command/assets.go on lines 105..114
          command/assets.go on lines 125..134
          command/assets.go on lines 165..174
          command/assets.go on lines 185..194

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language