Sign upLogin

jkawamoto/roadie

View on GitHub
Star

Showing 2,161 of 2,161 total issues

Function TestStop has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func TestStop(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
Severity: Minor
Found in cloud/mock/queue_test.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
Severity: Major
Found in cloud/azure/batch/models/pool_evaluate_auto_scale_parameter.go and 1 other location - About 2 hrs to fix
cloud/azure/batch/models/affinity_information.go on lines 1..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 230.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
Severity: Major
Found in cloud/azure/batch/models/affinity_information.go and 1 other location - About 2 hrs to fix
cloud/azure/batch/models/pool_evaluate_auto_scale_parameter.go on lines 1..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 230.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method JobListFromJobScheduleParams.WriteToRequest has 91 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (o *JobListFromJobScheduleParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
Severity: Major
Found in cloud/azure/batch/client/jobs/job_list_from_job_schedule_parameters.go - About 2 hrs to fix

    Method TaskListParams.WriteToRequest has 91 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (o *TaskListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
    Severity: Major
    Found in cloud/azure/batch/client/tasks/task_list_parameters.go - About 2 hrs to fix

      Method BatchService.CreateTask has 91 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (s *BatchService) CreateTask(ctx context.Context, job string, task *script.Script) (err error) {

    var resourceFiles []*models.ResourceFile

    // Update source section.
      Severity: Major
      Found in cloud/azure/batch.go - About 2 hrs to fix

        Function TestUploadSourceFiles has 90 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestUploadSourceFiles(t *testing.T) {

    var err error
    m := testMetadata(nil, nil)
    s, err := m.StorageManager()
        Severity: Major
        Found in command/source_test.go - About 2 hrs to fix

          Method TaskGetParams.WriteToRequest has 90 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (o *TaskGetParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
          Severity: Major
          Found in cloud/azure/batch/client/tasks/task_get_parameters.go - About 2 hrs to fix

            Method mockBatchAcountServer.ServeHTTP has 90 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (m *mockBatchAcountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
            Severity: Major
            Found in cloud/azure/batch_account_test.go - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
              Severity: Major
              Found in cloud/azure/resource/models/alias_path_type.go and 1 other location - About 2 hrs to fix
              cloud/azure/resource/models/resources_move_info.go on lines 1..46

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 226.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
              Severity: Major
              Found in cloud/azure/resource/models/resources_move_info.go and 1 other location - About 2 hrs to fix
              cloud/azure/resource/models/alias_path_type.go on lines 1..46

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 226.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method PoolDeleteParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *PoolDeleteParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/pools/pool_delete_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method PoolStopResizeParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *PoolStopResizeParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/pools/pool_stop_resize_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method JobDeleteParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *JobDeleteParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/jobs/job_delete_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method JobEnableParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *JobEnableParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/jobs/job_enable_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method PoolExistsParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *PoolExistsParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/pools/pool_exists_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method JobScheduleEnableParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *JobScheduleEnableParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/job_schedules/job_schedule_enable_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method JobScheduleExistsParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *JobScheduleExistsParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/job_schedules/job_schedule_exists_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method JobScheduleTerminateParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *JobScheduleTerminateParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/job_schedules/job_schedule_terminate_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method JobScheduleDisableParams.WriteToRequest has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
              Open

              func (o *JobScheduleDisableParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Minor
              Found in cloud/azure/batch/client/job_schedules/job_schedule_disable_parameters.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language