Sign upLogin

jkawamoto/roadie

View on GitHub
Star

Showing 2,161 of 2,161 total issues

Method JobScheduleUpdateParams.WriteToRequest has 69 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (o *JobScheduleUpdateParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
Severity: Minor
Found in cloud/azure/batch/client/job_schedules/job_schedule_update_parameters.go - About 1 hr to fix

    Method PoolRemoveNodesParams.WriteToRequest has 69 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (o *PoolRemoveNodesParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
    Severity: Minor
    Found in cloud/azure/batch/client/compute_nodes/pool_remove_nodes_parameters.go - About 1 hr to fix

      Method JobPatchParams.WriteToRequest has 69 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (o *JobPatchParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
      Severity: Minor
      Found in cloud/azure/batch/client/jobs/job_patch_parameters.go - About 1 hr to fix

        Method JobSchedulePatchParams.WriteToRequest has 69 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (o *JobSchedulePatchParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
        Severity: Minor
        Found in cloud/azure/batch/client/job_schedules/job_schedule_patch_parameters.go - About 1 hr to fix

          Function TestRestart has 69 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func TestRestart(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
          Severity: Minor
          Found in cloud/mock/queue_test.go - About 1 hr to fix

            Method ApplicationListParams.WriteToRequest has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
            Open

            func (o *ApplicationListParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
            Severity: Minor
            Found in cloud/azure/batch/client/applications/application_list_parameters.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function TestRestart has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
            Open

            func TestRestart(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
            Severity: Minor
            Found in cloud/mock/queue_test.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
            Severity: Major
            Found in cloud/azure/compute/models/virtual_machine_size.go and 2 other locations - About 1 hr to fix
            cloud/azure/batch/models/compute_node_information.go on lines 1..43
            cloud/azure/resource/models/sku.go on lines 1..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 171.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
            Severity: Major
            Found in cloud/azure/batch/models/compute_node_information.go and 2 other locations - About 1 hr to fix
            cloud/azure/compute/models/virtual_machine_size.go on lines 1..43
            cloud/azure/resource/models/sku.go on lines 1..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 171.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            package models

// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the swagger generate command
            Severity: Major
            Found in cloud/azure/resource/models/sku.go and 2 other locations - About 1 hr to fix
            cloud/azure/batch/models/compute_node_information.go on lines 1..43
            cloud/azure/compute/models/virtual_machine_size.go on lines 1..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 171.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function TestList has 67 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func TestList(t *testing.T) {

    var err error
    m := NewStorageManager()
    ctx := context.Background()
            Severity: Minor
            Found in cloud/mock/storage_test.go - About 1 hr to fix

              Method QueueService.Queues has 67 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (s *QueueService) Queues(ctx context.Context, handler cloud.QueueStatusHandler) (err error) {

    s.Logger.Println("Retrieving queue names")
    statusSet := make(map[string]cloud.QueueStatus)
              Severity: Minor
              Found in cloud/gcp/queue.go - About 1 hr to fix

                Function NewBatchService has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func NewBatchService(ctx context.Context, cfg *Config, logger *log.Logger) (service *BatchService, err error) {

    if logger == nil {
        logger = log.New(ioutil.Discard, "", log.LstdFlags)
    }
                Severity: Minor
                Found in cloud/azure/batch.go - About 1 hr to fix

                  Method TaskTerminateParams.WriteToRequest has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (o *TaskTerminateParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
                  Severity: Minor
                  Found in cloud/azure/batch/client/tasks/task_terminate_parameters.go - About 1 hr to fix

                    Method TaskReactivateParams.WriteToRequest has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (o *TaskReactivateParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
                    Severity: Minor
                    Found in cloud/azure/batch/client/tasks/task_reactivate_parameters.go - About 1 hr to fix

                      Method TaskDeleteParams.WriteToRequest has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (o *TaskDeleteParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
                      Severity: Minor
                      Found in cloud/azure/batch/client/tasks/task_delete_parameters.go - About 1 hr to fix

                        Function TestCreateWorkers has 65 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func TestCreateWorkers(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
                        Severity: Minor
                        Found in cloud/mock/queue_test.go - About 1 hr to fix

                          Function TestCmdRun has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
                          Open

                          func TestCmdRun(t *testing.T) {

    var err error
    tmp, err := ioutil.TempFile("", "")
    if err != nil {
                          Severity: Minor
                          Found in command/run_test.go - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method mockStorageAccountServer.ServeHTTP has 17 return statements (exceeds 4 allowed).
                          Open

                          func (m *mockStorageAccountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
                          Severity: Major
                          Found in cloud/azure/storage_test.go - About 1 hr to fix

                            Method mockBatchAcountServer.ServeHTTP has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
                            Open

                            func (m *mockBatchAcountServer) ServeHTTP(res http.ResponseWriter, req *http.Request) {

    paths := strings.Split(strings.TrimPrefix(req.URL.Path, "/"), "/")
    if len(paths) < 2 {
        res.WriteHeader(http.StatusBadRequest)
                            Severity: Minor
                            Found in cloud/azure/batch_account_test.go - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language