Sign upLogin

jkawamoto/roadie

View on GitHub
Star

Showing 2,161 of 2,161 total issues

Function TestTasks has 63 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestTasks(t *testing.T) {

    var err error
    ctx := context.Background()
    m := NewQueueManager()
Severity: Minor
Found in cloud/mock/queue_test.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if c.quiet {

            files := make(map[string]struct{})
            scanner := bufio.NewScanner(&output)
            for scanner.Scan() {
    Severity: Major
    Found in command/table_test.go and 1 other location - About 1 hr to fix
    command/table_test.go on lines 172..212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 160.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if c.quiet {

            files := make(map[string]struct{})
            scanner := bufio.NewScanner(&output)
            for scanner.Scan() {
    Severity: Major
    Found in command/table_test.go and 1 other location - About 1 hr to fix
    command/table_test.go on lines 72..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 160.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function AuthorizeDeviceCode has 61 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func AuthorizeDeviceCode(ctx context.Context, clientID string, output io.Writer) (token *adal.Token, err error) {

    code, err := GetDeviceCode(ctx, clientID)
    if err != nil {
        return
    Severity: Minor
    Found in cloud/azure/auth/device_authorizer.go - About 1 hr to fix

      Method FileDeleteFromTaskParams.WriteToRequest has 61 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (o *FileDeleteFromTaskParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
      Severity: Minor
      Found in cloud/azure/batch/client/files/file_delete_from_task_parameters.go - About 1 hr to fix

        Method FileDeleteFromComputeNodeParams.WriteToRequest has 61 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (o *FileDeleteFromComputeNodeParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
        Severity: Minor
        Found in cloud/azure/batch/client/files/file_delete_from_compute_node_parameters.go - About 1 hr to fix

          Method VirtualMachineExtensionImagesListVersionsParams.WriteToRequest has 61 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (o *VirtualMachineExtensionImagesListVersionsParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.timeout)
    var res []error
          Severity: Minor
          Found in cloud/azure/compute/client/virtual_machine_extension_images/virtual_machine_extension_images_list_versions_parameters.go - About 1 hr to fix

            Method Storage.DownloadFiles has 61 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (s *Storage) DownloadFiles(ctx context.Context, prefix *url.URL, dir string, queries []string) (err error) {

    var info os.FileInfo
    if info, err = os.Stat(dir); err != nil {
        // Given dir does not exist.
            Severity: Minor
            Found in cloud/storage.go - About 1 hr to fix

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              func CmdQueueStop(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
              Severity: Major
              Found in command/queue.go and 5 other locations - About 1 hr to fix
              command/config.go on lines 51..69
              command/config.go on lines 145..162
              command/config.go on lines 292..309
              command/queue.go on lines 309..326
              command/queue.go on lines 417..434

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              func CmdQueueInstanceList(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
              Severity: Major
              Found in command/queue.go and 5 other locations - About 1 hr to fix
              command/config.go on lines 51..69
              command/config.go on lines 145..162
              command/config.go on lines 292..309
              command/queue.go on lines 385..403
              command/queue.go on lines 417..434

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              func CmdConfigRegionSet(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
              Severity: Major
              Found in command/config.go and 5 other locations - About 1 hr to fix
              command/config.go on lines 51..69
              command/config.go on lines 145..162
              command/queue.go on lines 309..326
              command/queue.go on lines 385..403
              command/queue.go on lines 417..434

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              func CmdQueueRestart(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
              Severity: Major
              Found in command/queue.go and 5 other locations - About 1 hr to fix
              command/config.go on lines 51..69
              command/config.go on lines 145..162
              command/config.go on lines 292..309
              command/queue.go on lines 309..326
              command/queue.go on lines 385..403

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              func CmdConfigMachineTypeSet(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
              Severity: Major
              Found in command/config.go and 5 other locations - About 1 hr to fix
              command/config.go on lines 51..69
              command/config.go on lines 292..309
              command/queue.go on lines 309..326
              command/queue.go on lines 385..403
              command/queue.go on lines 417..434

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

              func CmdConfigProjectSet(c *cli.Context) (err error) {

    if c.NArg() != 1 {
        fmt.Printf("expected 1 argument. (%d given)\n", c.NArg())
        return cli.ShowSubcommandHelp(c)
              Severity: Major
              Found in command/config.go and 5 other locations - About 1 hr to fix
              command/config.go on lines 145..162
              command/config.go on lines 292..309
              command/queue.go on lines 309..326
              command/queue.go on lines 385..403
              command/queue.go on lines 417..434

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 156.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function TestUpdateResultSection has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
              Open

              func TestUpdateResultSection(t *testing.T) {

    var output bytes.Buffer
    testScript := script.Script{
        Name:   "test-script",
              Severity: Minor
              Found in command/helper_test.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function TestCmdConfigMachineTypeList has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
              Open

              func TestCmdConfigMachineTypeList(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
              Severity: Minor
              Found in command/config_test.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function TestCmdConfigRegionList has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
              Open

              func TestCmdConfigRegionList(t *testing.T) {

    var err error
    var output bytes.Buffer
    p := mock.NewProvider()
              Severity: Minor
              Found in command/config_test.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method TaskGetParams.WriteToRequest has 15 return statements (exceeds 4 allowed).
              Open

              func (o *TaskGetParams) WriteToRequest(r runtime.ClientRequest, reg strfmt.Registry) error {

    r.SetTimeout(o.requestTimeout)
    var res []error
              Severity: Major
              Found in cloud/azure/batch/client/tasks/task_get_parameters.go - About 1 hr to fix

                Method Storage.DownloadFiles has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                Open

                func (s *Storage) DownloadFiles(ctx context.Context, prefix *url.URL, dir string, queries []string) (err error) {

    var info os.FileInfo
    if info, err = os.Stat(dir); err != nil {
        // Given dir does not exist.
                Severity: Minor
                Found in cloud/storage.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function TestEnqueue has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                Open

                func TestEnqueue(t *testing.T) {

    ctx := context.Background()
    m := NewQueueManager()
                Severity: Minor
                Found in cloud/mock/queue_test.go - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language