Sign upLogin

jkphl/rdfa-lite-microdata

View on GitHub
Star

Showing 23 of 23 total issues

The method __construct has a boolean flag argument $iri, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($iri = false)
Severity: Minor
Found in src/RdfaLiteMicrodata/Infrastructure/Service/ThingGateway.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '70', column '20').
Open

        $dom = new \DOMDocument();
Severity: Minor
Found in src/RdfaLiteMicrodata/Tests/Application/DOMIteratorTest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using Jkphl\RdfaLiteMicrodata\Infrastructure\Parser\count() function in while loops.
Open

            while (count($prefixes)) {
                $prefix = rtrim(array_shift($prefixes), ':');
                $uri = array_shift($prefixes);
                $context = $context->registerVocabulary($prefix, $uri);
            }
Severity: Minor
Found in src/RdfaLiteMicrodata/Infrastructure/Parser/RdfaLiteElementProcessor.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Severity
Category
Status
Source
Language