Sign upLogin

jmdobry/reheat

View on GitHub
Star

Showing 296 of 296 total issues

Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (Promise, utils, errors) {
  var IllegalArgumentError = errors.IllegalArgumentError;

  /**
   * @doc method
Severity: Minor
Found in lib/model/prototype/unset.js - About 1 hr to fix

    Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (Promise, utils, errors, models) {
  /**
   * @doc method
   * @id Model.instance_methods:destroy
   * @name destroy
    Severity: Minor
    Found in lib/model/prototype/destroy.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sanitize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        return Promise.resolve().then(function sanitize() {
      if (!utils.isObject(options)) {
        throw new IllegalArgumentError(errorPrefix + 'options: Must be an object', { actual: typeof options, expected: 'object' });
      } else if (!utils.isObject(key) && !utils.isString(key)) {
        throw new IllegalArgumentError(errorPrefix + 'key: Must be a string or an object!', { actual: typeof key, expected: 'string|object' });
    Severity: Minor
    Found in lib/model/prototype/set.js - About 1 hr to fix

      Function reset has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        reset: function () {
    // 3rd-party dependencies
    container.register('r', function () {
      return require('rethinkdbdash');
    });
      Severity: Minor
      Found in lib/config.js - About 1 hr to fix

        Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (Promise, utils, errors) {
  var IllegalArgumentError = errors.IllegalArgumentError;

  /**
   * @doc method
        Severity: Minor
        Found in lib/model/prototype/clear.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            Collection.filter = function () {
    console.warn('Collection#filter is deprecated! Please use Collection#findAll.');
    var args = Array.prototype.slice(arguments);
    return this.findAll.apply(this, args);
  };
          Severity: Major
          Found in lib/collection/index.js and 1 other location - About 1 hr to fix
          lib/model/index.js on lines 99..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            Model.get = function () {
    console.warn('Model#get is deprecated! Please use Model#findOne.');
    var args = Array.prototype.slice(arguments);
    return this.findOne.apply(this, args);
  };
          Severity: Major
          Found in lib/model/index.js and 1 other location - About 1 hr to fix
          lib/collection/index.js on lines 82..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function isNew has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              isNew: function (test) {
        test.expect(2);

        var instance = {
            attributes: {
          Severity: Minor
          Found in old_test/reheat/model/prototype/index.test.js - About 1 hr to fix

            Function get has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                get: function (test) {
        test.expect(11);

        var instance = {
            attributes: {
            Severity: Minor
            Found in old_test/reheat/model/prototype/index.test.js - About 1 hr to fix

              Function unset has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function unset(key, options, cb) {
    var _this = this;

    // Check pre-conditions
    options = options ? (options === true ? { validate: true } : options) : {};
              Severity: Minor
              Found in lib/model/prototype/unset.js - About 1 hr to fix

                Function methodsExist has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    methodsExist: function (test) {
        test.expect(30);

        test.ok(typeof Model.get, 'function');
        test.ok(typeof Model.getAll, 'function');
                Severity: Minor
                Found in old_test/reheat/model/index.test.js - About 1 hr to fix

                  Function exports has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function (r, Promise, utils, errors) {

  /**
   * @doc function
   * @id Connection.class:constructor
                  Severity: Minor
                  Found in lib/connection/index.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    var posts = tempUser2.get(User.relations.hasMany.Post.localField),
                    comments = tempUser2.get(User.relations.hasMany.Comment.localField);
                    Severity: Major
                    Found in old_test/model/static/relations.test.js and 1 other location - About 1 hr to fix
                    old_test/model/static/relations.test.js on lines 389..390

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    var posts = tempUser.get(User.relations.hasMany.Post.localField),
                    comments = tempUser.get(User.relations.hasMany.Comment.localField);
                    Severity: Major
                    Found in old_test/model/static/relations.test.js and 1 other location - About 1 hr to fix
                    old_test/model/static/relations.test.js on lines 535..536

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function manyInsert has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        manyInsert: function (test) {
        test.expect(4003);

        connection.configure({
            max: 100
                    Severity: Minor
                    Found in old_test/connection/index.test.js - About 1 hr to fix

                      Function profile has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          profile: function (test) {
        test.expect(5);

        function Model(attrs) {
            this.attributes = attrs;
                      Severity: Minor
                      Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

                        Function profile has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            profile: function (test) {
        test.expect(5);

        function Model(attrs) {
            this.attributes = attrs;
                        Severity: Minor
                        Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                          Function exports has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          module.exports = function (container, utils, errors, Collection_prototype, Collection_findAll, Collection_getAll) {

  /**
   * @doc function
   * @name Collection
                          Severity: Minor
                          Found in lib/collection/index.js - About 1 hr to fix

                            Function clear has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              function clear(options, cb) {
    var _this = this;

    // Check pre-conditions
    options = options ? (options === true ? { validate: true } : options) : {};
                            Severity: Minor
                            Found in lib/model/prototype/clear.js - About 1 hr to fix

                              Function normalIsNew has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  normalIsNew: function (test) {
        test.expect(3);

        var instance = {
            attributes: {
                              Severity: Minor
                              Found in old_test/reheat/model/prototype/destroy.test.js - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language