Showing 296 of 296 total issues
Identical blocks of code found in 2 locations. Consider refactoring. Open
test.deepEqual(instance.meta, {
old_val: {
name: 'John',
id: 2
},
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function clear
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
function clear(options, cb) {
var _this = this;
// Check pre-conditions
options = options ? (options === true ? { validate: true } : options) : {};
Function validateWithError
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
validateWithError: function (test) {
test.expect(6);
var instance = {
attributes: {
Function validateWithError
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
validateWithError: function (test) {
test.expect(6);
var instance = {
attributes: {
Function link
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
link: function(scope, element, attrs) {
element.bind('click', function(){
element.addClass('loading');
Function exports
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
module.exports = function (utils, errors, Model_set, Model_setSync, Model_unset, Model_clear, Model_save, Model_destroy, Model_load) {
Function pluckMultiple
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
pluckMultiple: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function raw
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
raw: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function orderByArray
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
orderByArray: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function pluck
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
pluck: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function options
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
options: function (test) {
test.expect(8);
function Model(attrs) {
this.attributes = attrs;
Function limit
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
limit: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function normalKeyArray
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
normalKeyArray: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function skip
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
skip: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function orderBy
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
orderBy: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Function raw
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
raw: function (test) {
test.expect(5);
function Model(attrs) {
this.attributes = attrs;
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (!utils.isObject(options)) {
throw new IllegalArgumentError(errorPrefix + 'options: Must be an object!', { actual: typeof options, expected: 'object' });
} else if (!utils.isObject(key) && !utils.isString(key)) {
throw new IllegalArgumentError(errorPrefix + 'key: Must be a string or an object!', { actual: typeof key, expected: 'string|object' });
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (!utils.isObject(options)) {
throw new IllegalArgumentError(errorPrefix + 'options: Must be an object', { actual: typeof options, expected: 'object' });
} else if (!utils.isObject(key) && !utils.isString(key)) {
throw new IllegalArgumentError(errorPrefix + 'key: Must be a string or an object!', { actual: typeof key, expected: 'string|object' });
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
}, function (err, instance) {
test.ifError(err);
test.deepEqual(instance.attributes, {
address: {
state: 'TX'
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
instance.set('address.state', 'TX', function (err, instance) {
test.ifError(err);
test.deepEqual(instance.attributes, {
address: {
state: 'TX'
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76