jmdobry/reheat

View on GitHub

Showing 296 of 296 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            test.deepEqual(instance.meta, {
                old_val: {
                    name: 'John',
                    id: 2
                },
Severity: Major
Found in old_test/reheat/model/prototype/destroy.test.js and 1 other location - About 1 hr to fix
old_test/reheat/model/prototype/destroy.test.js on lines 333..344

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function clear has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function clear(options, cb) {
    var _this = this;

    // Check pre-conditions
    options = options ? (options === true ? { validate: true } : options) : {};
Severity: Minor
Found in lib/model/prototype/clear.js - About 1 hr to fix

    Function validateWithError has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        validateWithError: function (test) {
            test.expect(6);
    
            var instance = {
                attributes: {
    Severity: Minor
    Found in old_test/reheat/model/prototype/clear.test.js - About 1 hr to fix

      Function validateWithError has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          validateWithError: function (test) {
              test.expect(6);
      
              var instance = {
                  attributes: {
      Severity: Minor
      Found in old_test/reheat/model/prototype/unset.test.js - About 1 hr to fix

        Function link has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                link: function(scope, element, attrs) {
        
                    element.bind('click', function(){
        
                        element.addClass('loading');
        Severity: Minor
        Found in guide/reheat.js - About 1 hr to fix

          Function exports has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports = function (utils, errors, Model_set, Model_setSync, Model_unset, Model_clear, Model_save, Model_destroy, Model_load) {
          Severity: Major
          Found in lib/model/prototype/index.js - About 1 hr to fix

            Function pluckMultiple has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                pluckMultiple: function (test) {
                    test.expect(5);
            
                    function Model(attrs) {
                        this.attributes = attrs;
            Severity: Minor
            Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

              Function raw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  raw: function (test) {
                      test.expect(5);
              
                      function Model(attrs) {
                          this.attributes = attrs;
              Severity: Minor
              Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                Function orderByArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    orderByArray: function (test) {
                        test.expect(5);
                
                        function Model(attrs) {
                            this.attributes = attrs;
                Severity: Minor
                Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                  Function pluck has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      pluck: function (test) {
                          test.expect(5);
                  
                          function Model(attrs) {
                              this.attributes = attrs;
                  Severity: Minor
                  Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                    Function options has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        options: function (test) {
                            test.expect(8);
                    
                            function Model(attrs) {
                                this.attributes = attrs;
                    Severity: Minor
                    Found in old_test/reheat/model/static/get.test.js - About 1 hr to fix

                      Function limit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          limit: function (test) {
                              test.expect(5);
                      
                              function Model(attrs) {
                                  this.attributes = attrs;
                      Severity: Minor
                      Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                        Function normalKeyArray has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            normalKeyArray: function (test) {
                                test.expect(5);
                        
                                function Model(attrs) {
                                    this.attributes = attrs;
                        Severity: Minor
                        Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

                          Function skip has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              skip: function (test) {
                                  test.expect(5);
                          
                                  function Model(attrs) {
                                      this.attributes = attrs;
                          Severity: Minor
                          Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                            Function orderBy has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                orderBy: function (test) {
                                    test.expect(5);
                            
                                    function Model(attrs) {
                                        this.attributes = attrs;
                            Severity: Minor
                            Found in old_test/reheat/model/static/filter.test.js - About 1 hr to fix

                              Function raw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  raw: function (test) {
                                      test.expect(5);
                              
                                      function Model(attrs) {
                                          this.attributes = attrs;
                              Severity: Minor
                              Found in old_test/reheat/model/static/getAll.test.js - About 1 hr to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (!utils.isObject(options)) {
                                      throw new IllegalArgumentError(errorPrefix + 'options: Must be an object!', { actual: typeof options, expected: 'object' });
                                    } else if (!utils.isObject(key) && !utils.isString(key)) {
                                      throw new IllegalArgumentError(errorPrefix + 'key: Must be a string or an object!', { actual: typeof key, expected: 'string|object' });
                                    }
                                Severity: Major
                                Found in lib/model/prototype/setSync.js and 1 other location - About 1 hr to fix
                                lib/model/prototype/set.js on lines 124..128

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      if (!utils.isObject(options)) {
                                        throw new IllegalArgumentError(errorPrefix + 'options: Must be an object', { actual: typeof options, expected: 'object' });
                                      } else if (!utils.isObject(key) && !utils.isString(key)) {
                                        throw new IllegalArgumentError(errorPrefix + 'key: Must be a string or an object!', { actual: typeof key, expected: 'string|object' });
                                      }
                                Severity: Major
                                Found in lib/model/prototype/set.js and 1 other location - About 1 hr to fix
                                lib/model/prototype/setSync.js on lines 76..80

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        }, function (err, instance) {
                                            test.ifError(err);
                                            test.deepEqual(instance.attributes, {
                                                address: {
                                                    state: 'TX'
                                Severity: Major
                                Found in old_test/reheat/model/prototype/set.test.js and 1 other location - About 1 hr to fix
                                old_test/reheat/model/prototype/set.test.js on lines 46..55

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        instance.set('address.state', 'TX', function (err, instance) {
                                            test.ifError(err);
                                            test.deepEqual(instance.attributes, {
                                                address: {
                                                    state: 'TX'
                                Severity: Major
                                Found in old_test/reheat/model/prototype/set.test.js and 1 other location - About 1 hr to fix
                                old_test/reheat/model/prototype/set.test.js on lines 78..87

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 57.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language