Sign upLogin

jnidzwetzki/bboxdb

View on GitHub
Star
bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java

Summary

Maintainability
A
45 mins
Test Coverage

Method getIntersection has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Invalid

    public DoubleInterval getIntersection(final DoubleInterval otherInterval) {
        
        if(otherInterval == null) {
            return null;
        }
Severity: Minor
Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File DoubleInterval.java has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *  
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Minor
Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 2 hrs to fix

    Method overlapsWith has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Invalid

        public boolean overlapsWith(final double number, final boolean numberIncluded) {
        
        boolean betweenBeginAndEnd = (number >= begin && number <= end);
        
        if(betweenBeginAndEnd == false) {
    Severity: Minor
    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getIntersection has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        public DoubleInterval getIntersection(final DoubleInterval otherInterval) {
        
        if(otherInterval == null) {
            return null;
        }
    Severity: Minor
    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 1 hr to fix

      Method isCovering has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Invalid

          public boolean isCovering(final DoubleInterval otherInterval) {
        if(otherInterval.getBegin() < getBegin()) {
            return false;
        }
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getRoundedString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public String getRoundedString(final int precision) {
        final StringBuffer sb = new StringBuffer();
        
        if(beginIncluded) {
            sb.append("[");
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method equals has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Invalid

          @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Invalid

              return true;
      Severity: Major
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Invalid

                    return new DoubleInterval(otherInterval.getBegin(), end, otherInterval.isBeginIncluded(), endIncluded);
        Severity: Major
        Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Invalid

                  return false;
          Severity: Major
          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Invalid

                    return true;
            Severity: Major
            Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Invalid

                          return false;
              Severity: Major
              Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Invalid

                        return new DoubleInterval(begin, otherInterval.getEnd(), beginIncluded, otherInterval.isEndIncluded());
                Severity: Major
                Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Invalid

                              return false;
                  Severity: Major
                  Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Invalid

                                return null;
                    Severity: Major
                    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Invalid

                                      return null;
                      Severity: Major
                      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Invalid

                                    return null;
                        Severity: Major
                        Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Invalid

                                          return new DoubleInterval(begin, Math.min(getEnd(), otherInterval.getEnd()), true, true);
                          Severity: Major
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Invalid

                                            return false;
                            Severity: Major
                            Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Invalid

                                          return false;
                              Severity: Major
                              Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Invalid

                                        return true;
                                Severity: Major
                                Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Invalid

                                              if("min".equals(beginEnd[0])) {
                this.begin = MIN_VALUE;
            } else {
                this.begin = MathUtil.tryParseDouble(beginEnd[0], () -> "Unable to parse: " + beginEnd[0]);
            }
                                  Severity: Minor
                                  Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java and 1 other location - About 50 mins to fix
                                  bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java on lines 87..91

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 58.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Invalid

                                              if("max".equals(beginEnd[1])) {
                this.end = MAX_VALUE;
            } else {
                this.end = MathUtil.tryParseDouble(beginEnd[1], () -> "Unable to parse: " + beginEnd[1]);
            }
                                  Severity: Minor
                                  Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java and 1 other location - About 50 mins to fix
                                  bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java on lines 81..85

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 58.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Invalid

                                      public DoubleInterval splitAndGetLeftPart(final double splitPosition, final boolean splitPositionIncluded) {
        if(! overlapsWith(splitPosition, true)) {
            throw new IllegalArgumentException("Split position is not included: " + toString() + " / " + splitPosition);
        }
                                  Severity: Minor
                                  Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java and 1 other location - About 35 mins to fix
                                  bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java on lines 375..381

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 47.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Invalid

                                      public DoubleInterval splitAndGetRightPart(final double splitPosition, final boolean splitPositionIncluded) {
        if(! overlapsWith(splitPosition, true)) {
            throw new IllegalArgumentException("Split position is not included: " + toString() + " / " + splitPosition);
        }
                                  Severity: Minor
                                  Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java and 1 other location - About 35 mins to fix
                                  bboxdb-commons/src/main/java/org/bboxdb/commons/math/DoubleInterval.java on lines 363..369

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 47.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status