Sign upLogin

jnidzwetzki/bboxdb

View on GitHub
Star
bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java

Summary

Maintainability
C
1 day
Test Coverage

Method equals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
Severity: Minor
Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fromGeoJson has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static GeoJsonPolygon fromGeoJson(final String jsonData) {
        final JSONTokener tokener = new JSONTokener(jsonData);
        final JSONObject jsonObject = new JSONObject(tokener);
        final Long objectId = jsonObject.optLong(JSON_ID, -1);
Severity: Minor
Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 1 hr to fix

    Method fromGeoJson has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public static GeoJsonPolygon fromGeoJson(final String jsonData) {
        final JSONTokener tokener = new JSONTokener(jsonData);
        final JSONObject jsonObject = new JSONObject(tokener);
        final Long objectId = jsonObject.optLong(JSON_ID, -1);
    Severity: Minor
    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method buildJSON has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected JSONObject buildJSON() {
        final JSONObject featureJson = new JSONObject();
        featureJson.put(JSON_TYPE, JSON_FEATURE);
        featureJson.put(JSON_ID, id);
    Severity: Minor
    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 1 hr to fix

      Method buildJSON has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected JSONObject buildJSON() {
        final JSONObject featureJson = new JSONObject();
        featureJson.put(JSON_TYPE, JSON_FEATURE);
        featureJson.put(JSON_ID, id);
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return true;
              Severity: Major
              Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Invalid

                    @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
                Severity: Major
                Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java and 1 other location - About 2 hrs to fix
                bboxdb-commons/src/main/java/org/bboxdb/commons/entity/PersonEntity.java on lines 58..80

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 150.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            for(int i = 0; i < coordinates.length(); i++) {
                final JSONArray jsonArray = coordinates.getJSONArray(i);
                final double coordiante0 = jsonArray.getDouble(0);
                final double coordiante1 = jsonArray.getDouble(1);
                polygon.addPoint(coordiante0, coordiante1);
                Severity: Minor
                Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java and 1 other location - About 1 hr to fix
                bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java on lines 310..315

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 68.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            for(int i = 0; i < coordinatesArray.length(); i++) {
                final JSONArray jsonArray = coordinatesArray.getJSONArray(i);
                final double coordiante0 = jsonArray.getDouble(0);
                final double coordiante1 = jsonArray.getDouble(1);
                polygon.addPoint(coordiante0, coordiante1);
                Severity: Minor
                Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java and 1 other location - About 1 hr to fix
                bboxdb-commons/src/main/java/org/bboxdb/commons/math/GeoJsonPolygon.java on lines 301..306

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 68.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status