Sign upLogin

jnidzwetzki/bboxdb

View on GitHub
Star
bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java

Summary

Maintainability
D
1 day
Test Coverage

File Hyperrectangle.java has 470 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

/*******************************************************************************
 *
 *    Copyright (C) 2015-2022 the BBoxDB project
 *
 *    Licensed under the Apache License, Version 2.0 (the "License");
Severity: Minor
Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 7 hrs to fix

    Hyperrectangle has 36 methods (exceeds 20 allowed). Consider refactoring.
    Invalid

    public class Hyperrectangle implements Comparable<Hyperrectangle> {

    /**
     * This special bounding box covers every space completely
     */
    Severity: Minor
    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 4 hrs to fix

      Method isCovering has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public boolean isCovering(final Hyperrectangle otherBox) {
        if(this == FULL_SPACE || otherBox == FULL_SPACE) {
            return true;
        }
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getCoveringBox has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public static Hyperrectangle getCoveringBox(final List<Hyperrectangle> boundingBoxes) {

        final int elements = boundingBoxes.size();

        if(elements == 0) {
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getCoveringBox has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static Hyperrectangle getCoveringBox(final List<Hyperrectangle> boundingBoxes) {

        final int elements = boundingBoxes.size();

        if(elements == 0) {
      Severity: Minor
      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 1 hr to fix

        Method intersects has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public boolean intersects(final Hyperrectangle otherBoundingBox) {

        // Null does overlap with nothing
        if(otherBoundingBox == null) {
            return false;
        Severity: Minor
        Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 1 hr to fix

          Method intersects has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public boolean intersects(final Hyperrectangle otherBoundingBox) {

        // Null does overlap with nothing
        if(otherBoundingBox == null) {
            return false;
          Severity: Minor
          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method compareTo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public int compareTo(final Hyperrectangle otherBox) {

        // Check number od dimensions
        if(getDimension() != otherBox.getDimension()) {
          Severity: Minor
          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method equals has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public boolean equals(Object obj) {
        if (this == obj)
            return true;
        if (obj == null)
          Severity: Minor
          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return false;
              Severity: Major
              Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return true;
                Severity: Major
                Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return true;
                  Severity: Major
                  Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return true;
                    Severity: Major
                    Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return true;
                      Severity: Major
                      Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 30 mins to fix

                          Method coversAtLeastOneDimensionComplete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public boolean coversAtLeastOneDimensionComplete(final Hyperrectangle hyperrectangle) {
        
        if(this == FULL_SPACE || hyperrectangle == FULL_SPACE) {
            return true;
        }
                          Severity: Minor
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method getCoveringBox has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static Hyperrectangle getCoveringBox(final Hyperrectangle hyperrectangle1,
            final Hyperrectangle hyperrectangle2) {

        if(hyperrectangle1 == FULL_SPACE) {
            return hyperrectangle2;
                          Severity: Minor
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method getIntersection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public Hyperrectangle getIntersection(final Hyperrectangle otherBox) {

        if(getDimension() == 0 || otherBox.getDimension() == 0) {
            return FULL_SPACE;
        }
                          Severity: Minor
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method scaleVolumeByPercentage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public Hyperrectangle scaleVolumeByPercentage(final double percentage) {
        
        // Don't scale the full space
        if(this == FULL_SPACE) {
            return null;
                          Severity: Minor
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if(otherBox.getCoordinateHigh(d) == getCoordinateHigh(d)) {
                if(isHighPointIncluded(d) == false && otherBox.isHighPointIncluded(d) == true) {
                    return false;
                }
            }
                          Severity: Minor
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java and 1 other location - About 35 mins to fix
                          bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java on lines 715..719

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 44.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if(otherBox.getCoordinateLow(d) == getCoordinateLow(d)) {
                if(isLowPointIncluded(d) == false && otherBox.isLowPointIncluded(d) == true) {
                    return false;
                }
            }
                          Severity: Minor
                          Found in bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java and 1 other location - About 35 mins to fix
                          bboxdb-commons/src/main/java/org/bboxdb/commons/math/Hyperrectangle.java on lines 721..725

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 44.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status