Sign upLogin

jnidzwetzki/bboxdb

View on GitHub
Star
bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method proxyBytesToTuple has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static Tuple proxyBytesToTuple(final byte[] bytes) throws IOException {

        try {
            if(bytes == null) {
                throw new IOException("Unable to handle a null argument");
Severity: Minor
Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java - About 1 hr to fix

    Method proxyBytesToJoinedTuple has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static MultiTuple proxyBytesToJoinedTuple(final byte[] bytes) throws IOException {
        try {
            if(bytes == null) {
                throw new IOException("Unable to handle a null argument");
            }
    Severity: Minor
    Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java - About 1 hr to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                  for(int i = 0; i < amountOfEntries; i++) {
                final int nameLength = bb.getInt();
                final byte[] nameBytes = new byte[nameLength];
                bb.get(nameBytes, 0, nameBytes.length);
                final String tableName = new String(nameBytes);
      Severity: Major
      Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java and 2 other locations - About 1 hr to fix
      bboxdb-server/src/main/java/org/bboxdb/network/packets/response/ContinuousQueryStateResponse.java on lines 176..182
      bboxdb-server/src/main/java/org/bboxdb/network/packets/response/ContinuousQueryStateResponse.java on lines 200..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static MultiTuple readJoinedTuple(final InputStream reader) throws IOException {
        final int tupleLength = DataEncoderHelper.readIntFromStream(reader);
        final byte[] tupleBytes = new byte[tupleLength];

        ByteStreams.readFully(reader, tupleBytes);
      Severity: Minor
      Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java and 1 other location - About 35 mins to fix
      bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java on lines 60..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static Tuple readTuple(final InputStream reader) throws IOException {
        final int tupleLength = DataEncoderHelper.readIntFromStream(reader);
        final byte[] tupleBytes = new byte[tupleLength];

        ByteStreams.readFully(reader, tupleBytes);
      Severity: Minor
      Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java and 1 other location - About 35 mins to fix
      bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java on lines 88..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static void writeTuple(final Tuple tuple, final OutputStream outputStream) throws IOException {
        final byte[] tupleData = TupleStringSerializer.tupleToProxyBytes(tuple);

        outputStream.write(DataEncoderHelper.intToByteBuffer(tupleData.length).array());
        outputStream.write(tupleData);
      Severity: Minor
      Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java and 1 other location - About 30 mins to fix
      bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java on lines 75..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static void writeJoinedTuple(final MultiTuple tuple, final OutputStream outputStream) throws IOException {
        final byte[] tupleData = TupleStringSerializer.joinedTupleToProxyBytes(tuple);

        outputStream.write(DataEncoderHelper.intToByteBuffer(tupleData.length).array());
        outputStream.write(tupleData);
      Severity: Minor
      Found in bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java and 1 other location - About 30 mins to fix
      bboxdb-network-proxy/src/main/java/org/bboxdb/networkproxy/misc/TupleStringSerializer.java on lines 47..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status