Sign upLogin

johnsonjh/gfsmux

View on GitHub
Star

Showing 29 of 29 total issues

Method Stream.waitRead has 7 return statements (exceeds 4 allowed).
Open

func (
    s *Stream,
) waitRead() error {
    var timer *time.Timer
    var deadline <-chan time.Time
Severity: Major
Found in stream.go - About 45 mins to fix

    Method Session.recvLoop has 6 return statements (exceeds 4 allowed).
    Open

    func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
    Severity: Major
    Found in session.go - About 40 mins to fix

      Method Stream.tryReadv2 has 5 return statements (exceeds 4 allowed).
      Open

      func (
    s *Stream,
) tryReadv2(
    b []byte,
) (
      Severity: Major
      Found in stream.go - About 35 mins to fix

        Method Stream.tryRead has 5 return statements (exceeds 4 allowed).
        Open

        func (
    s *Stream,
) tryRead(
    b []byte,
) (
        Severity: Major
        Found in stream.go - About 35 mins to fix

          Method Session.AcceptStream has 5 return statements (exceeds 4 allowed).
          Open

          func (
    s *Session,
) AcceptStream() (
    *Stream,
    error,
          Severity: Major
          Found in session.go - About 35 mins to fix

            Method Stream.writeTov2 has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func (
    s *Stream,
) writeTov2(
    w io.Writer,
) (
            Severity: Minor
            Found in stream.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            BUG found
            Open

                    // BUG(xtaci): Fix for https://github.com/xtaci/smux/issues/82 // XXX
            Severity: Minor
            Found in stream.go by fixme

            XXX found
            Open

            .XXX
            Severity: Minor
            Found in .gitignore by fixme

            XXX found
            Open

                    // BUG(xtaci): Fix for https://github.com/xtaci/smux/issues/82 // XXX
            Severity: Minor
            Found in stream.go by fixme
            Severity
            Category
            Status
            Source
            Language