Sign upLogin

johnsonjh/gfsmux

View on GitHub
Star
session.go

Summary

Maintainability
F
3 days
Test Coverage

File session.go has 709 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package gfsmux

import (
    "container/heap"
    "encoding/binary"
Severity: Minor
Found in session.go - About 7 hrs to fix

    Method Session.recvLoop has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
    Open

    func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
    Severity: Minor
    Found in session.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Session.recvLoop has 113 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
    Severity: Major
    Found in session.go - About 3 hrs to fix

      Session has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type Session struct {
    Conn io.ReadWriteCloser

    Config           *Config
    nextStreamID     uint32 // next stream identifier
      Severity: Minor
      Found in session.go - About 2 hrs to fix

        Method Session.sendLoop has 67 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (
    s *Session,
) sendLoop() {
    var buf []byte
    var n int
        Severity: Minor
        Found in session.go - About 1 hr to fix

          Method Session.OpenStream has 8 return statements (exceeds 4 allowed).
          Open

          func (
    s *Session,
) OpenStream() (
    *Stream,
    error,
          Severity: Major
          Found in session.go - About 50 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if written, err := io.ReadFull(
                        s.Conn,
                        newbuf,
                    ); err == nil {
                        s.streamLock.Lock()
            Severity: Major
            Found in session.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if stream, ok := s.streams[Sid]; ok {
                        stream.update(
                            updHdr.Consumed(),
                            updHdr.Window(),
                        )
              Severity: Major
              Found in session.go - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    select {
                    case s.chAccepts <- stream:
                    case <-s.die:
                    }
                Severity: Major
                Found in session.go - About 45 mins to fix

                  Method Session.WriteFrameInternal has 7 return statements (exceeds 4 allowed).
                  Open

                  func (
    s *Session,
) WriteFrameInternal(
    f Frame,
    deadline <-chan time.Time,
                  Severity: Major
                  Found in session.go - About 45 mins to fix

                    Method Session.recvLoop has 6 return statements (exceeds 4 allowed).
                    Open

                    func (
    s *Session,
) recvLoop() {
    var hdr rawHeader
    var updHdr updHeader
                    Severity: Major
                    Found in session.go - About 40 mins to fix

                      Method Session.AcceptStream has 5 return statements (exceeds 4 allowed).
                      Open

                      func (
    s *Session,
) AcceptStream() (
    *Stream,
    error,
                      Severity: Major
                      Found in session.go - About 35 mins to fix

                        There are no issues that match your filters.

                        Category
                        Status