Sign upLogin

johnthagen/eote-dice

View on GitHub
Star
dice.py

Summary

Maintainability
C
1 day
Test Coverage

File dice.py has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python3

"""Statical distribution needed for analyzing EotE dice."""

import collections
Severity: Minor
Found in dice.py - About 3 hrs to fix

    Function _cancel_symbols has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def _cancel_symbols(symbols: Sequence[Symbol]) -> List[Symbol]:
        net_success = 0
        net_advantage = 0

        # Do not inspect Triumph or Despair, because they do not cancel out.
    Severity: Minor
    Found in dice.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __str__ has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def __str__(self):  # pragma: no cover
        if self.triumph > 0.0:
            triumph_color = colorama.Fore.GREEN
        else:
            triumph_color = colorama.Fore.RESET
    Severity: Minor
    Found in dice.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _sort_dice_by_power has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def _sort_dice_by_power(dice_char: str) -> int:
        try:
            dice_color = DiceColor[dice_char]
            if dice_color is DiceColor.y:
                return 1
    Severity: Minor
    Found in dice.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                    return 5
    Severity: Major
    Found in dice.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 5
      Severity: Major
      Found in dice.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return 6
        Severity: Major
        Found in dice.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return 6
          Severity: Major
          Found in dice.py - About 30 mins to fix

            Function _sort_symbol_by_power has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def _sort_symbol_by_power(symbol: Symbol) -> int:
        if symbol is Symbol.Triumph:
            return 1
        elif symbol is Symbol.Success:
            return 2
            Severity: Minor
            Found in dice.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status