Sign upLogin

jon48/webtrees-lib

View on GitHub
Star

Showing 758 of 758 total issues

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'title'.
Open

        return I18N::translate('Columns extender for tables of ancestors’ families');
Severity: Minor
Found in app/Module/Hooks/Hooks/SosaFamilyDatatablesExtenderCollector.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'updateSpecificSettings'.
Open

                I18N::translate(
                    'An error occured while updating the specific settings of administrative task “%s”.',
                    $task->name()
                ),
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskEditAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'title'.
Open

        return I18N::translate('All events places by century');
Severity: Minor
Found in app/Module/GeoDispersion/GeoAnalyses/AllEventsByCenturyGeoAnalysis.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\Place' in method 'withConfigUpdate'.
Open

            $place = Place::find((int) $top_place_id, $tree);
Severity: Minor
Found in app/Module/GeoDispersion/PlaceMappers/Config/FilteredTopPlaceMapperConfig.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'label'.
Open

                        return I18N::translate('%s sourced with a certificate', $context_label);
Severity: Minor
Found in app/Module/IsSourced/Data/FactSourceStatus.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'description'.
Open

        return I18N::translate('Indicate if events related to an record are sourced.');
Severity: Minor
Found in app/Module/IsSourced/IsSourcedModule.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$router'.
Open

    public function loadRoutes(Map $router): void
Severity: Minor
Found in app/Module/ModuleMyArtJaubTrait.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method all uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $hook_instances->add($hook);
                }
Severity: Minor
Found in app/Module/Hooks/Services/HookService.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'label'.
Open

            return I18N::translate('%s not precise', $context_label);
Severity: Minor
Found in app/Module/IsSourced/Data/FactSourceStatus.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Carbon\CarbonImmutable' in method 'run'.
Open

                    ->lessThan(CarbonImmutable::now('UTC'))
Severity: Minor
Found in app/Module/AdminTasks/Services/TaskScheduleService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                I18N::translate('The task shedule with ID “%s” does not exist.', I18N::number($task_sched_id)),
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskStatusAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                I18N::translate('The task shedule with ID “%s” does not exist.', I18N::number($task_sched_id)),
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskStatusAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'boot'.
Open

            'OBJE:SOUR:_ACT'    =>  new SourceCertificate(I18N::translate('Certificate'), $this),
Severity: Minor
Found in app/Module/Certificates/CertificatesModule.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
Severity: Minor
Found in app/Module/PatronymicLineage/Http/RequestHandlers/LineagesPage.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\FlashMessages' in method 'handle'.
Open

            FlashMessages::addMessage(
                I18N::translate('The scheduled task has been successfully updated.'),
                'success'
            );
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskStatusAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

            throw new HttpNotFoundException(I18N::translate('The attached module could not be found.'));
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskTrigger.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                I18N::translate('The scheduled task has been successfully updated.'),
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TaskStatusAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\GedcomRecord' in method 'linkedNotes'.
Open

            ->filter(GedcomRecord::accessFilter());
Severity: Minor
Found in app/Module/Certificates/Services/CertificateDataService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                        'text_no' => I18N::translate('Not running')
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TasksList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Fisharebest\Webtrees\I18N' in method 'handle'.
Open

                        I18N::translate('Unlimited'),
Severity: Minor
Found in app/Module/AdminTasks/Http/RequestHandlers/TasksList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language