Sign upLogin

jpweeks/particulate-js

View on GitHub
Star

Showing 9 of 9 total issues

Function applyConstraint has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

AngleConstraint.prototype.applyConstraint = function (index, p0, p1) {
  /*jshint maxcomplexity:15*/

  var ii = this.indices
  var ai = ii[index], bi = ii[index + 1], ci = ii[index + 2]
Severity: Major
Found in src/constraints/AngleConstraint.js - About 3 hrs to fix

    Function _calculateNormal has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    PlaneConstraint.prototype._calculateNormal = function (index, p0) {
  var b0 = this.bufferVec3
  var ii = this.indices
  var ai = ii[0], bi = ii[1], ci = ii[2]
    Severity: Minor
    Found in src/constraints/PlaneConstraint.js - About 1 hr to fix

      Function applyConstraint has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      AngleConstraint.prototype.applyConstraint = function (index, p0, p1) {
  /*jshint maxcomplexity:15*/

  var ii = this.indices
  var ai = ii[index], bi = ii[index + 1], ci = ii[index + 2]
      Severity: Minor
      Found in src/constraints/AngleConstraint.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyForce has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      PointForce.prototype.applyForce = function (ix, f0, p0, p1) {
  var v0 = this.vector
  var iy = ix + 1
  var iz = ix + 2
      Severity: Minor
      Found in src/forces/PointForce.js - About 1 hr to fix

        Function ps_integrateParticle has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function ps_integrateParticle(i, p0, p1, f0, weight, d2) {
        Severity: Minor
        Found in src/systems/ParticleSystem.js - About 45 mins to fix

          Function set has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          Vec3.set = function (b0, i, x, y, z) {
          Severity: Minor
          Found in src/math/Vec3.js - About 35 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            BoxConstraint.prototype.setMin = function (x, y, z) {
  Vec3.set(this.bufferVec3, 0, x, y, z)
}
            Severity: Minor
            Found in src/constraints/BoxConstraint.js and 2 other locations - About 35 mins to fix
            src/constraints/BoundingPlaneConstraint.js on lines 93..95
            src/forces/Force.js on lines 63..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            BoundingPlaneConstraint.prototype.setOrigin = function (x, y, z) {
  Vec3.set(this.bufferVec3, 0, x, y, z)
}
            Severity: Minor
            Found in src/constraints/BoundingPlaneConstraint.js and 2 other locations - About 35 mins to fix
            src/constraints/BoxConstraint.js on lines 91..93
            src/forces/Force.js on lines 63..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            Force.prototype.set = function (x, y, z) {
  Vec3.set(this.vector, 0, x, y, z)
}
            Severity: Minor
            Found in src/forces/Force.js and 2 other locations - About 35 mins to fix
            src/constraints/BoundingPlaneConstraint.js on lines 93..95
            src/constraints/BoxConstraint.js on lines 91..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language