Method has too many lines. [48/30] Open
def self.filter(user, filters, bump_problem)
problems = Problem.search do
any_of do
with(:instructor_id, user.id)
with(:is_public, true)- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Cyclomatic complexity for filter is too high. [9/6] Open
def self.filter(user, filters, bump_problem)
problems = Problem.search do
any_of do
with(:instructor_id, user.id)
with(:is_public, true)- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Method filter has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.filter(user, filters, bump_problem)
problems = Problem.search do
any_of do
with(:instructor_id, user.id)
with(:is_public, true)Method filter has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.filter(user, filters, bump_problem)
problems = Problem.search do
any_of do
with(:instructor_id, user.id)
with(:is_public, true)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method html5 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def html5
if rendered_text
return rendered_text
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Put one space between the method name and the first argument. Open
integer :collection_ids, :multiple => true do- Read upRead up
- Exclude checks
Checks that exactly one space is used between a method name and the first argument for method calls without parentheses.
Alternatively, extra spaces can be added to align the argument with something on a preceding or following line, if the AllowForAlignment config parameter is true.
Example:
# bad
something x
something y, z
something'hello'
# good
something x
something y, z
something 'hello'