Sign upLogin

jumaallan/AndelaCryptoApp

View on GitHub
Star
app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java

Summary

Maintainability
B
6 hrs
Test Coverage

File CardsAdapter.java has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.androidstudy.andelatrackchallenge.adapter;

import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.content.Context;
Severity: Minor
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java - About 3 hrs to fix

    Method showEmptyView has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void showEmptyView(boolean show) {
        if (emptyView != null) {
            if (show) {
                emptyView.setVisibility(View.VISIBLE);
                emptyView.setAlpha(0.0f);
    Severity: Minor
    Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  itemView.setOnClickListener(v -> {
                if (onItemClickListener != null) {
                    int position = getAdapterPosition();
                    onItemClickListener.onItemClick(countries.get(position), position);
                }
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java and 1 other location - About 30 mins to fix
      app/src/main/java/com/androidstudy/andelatrackchallenge/picker/currency/CurrencyAdapter.java on lines 69..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  btcTextView.setText(country.btc > 0
                    ? String.format(Locale.getDefault(), currencyFormat, country.code, CurrencyUtils.format.format(btcCountry))
                    : "...");
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java and 1 other location - About 30 mins to fix
      app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java on lines 300..302

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  ethTextView.setText(country.eth > 0
                    ? String.format(Locale.getDefault(), currencyFormat, country.code, CurrencyUtils.format.format(ethCountry))
                    : "...");
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java and 1 other location - About 30 mins to fix
      app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java on lines 296..298

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status