Sign upLogin

jumaallan/AndelaCryptoApp

View on GitHub
Star

Showing 56 of 56 total issues

File InkPageIndicator.java has 640 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.androidstudy.andelatrackchallenge.widget;

import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.animation.AnimatorSet;
Severity: Major
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 day to fix

    File Easel.java has 370 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.androidstudy.andelatrackchallenge.utils;

/**
 * Created by anonymous on 11/2/17.
 */
    Severity: Minor
    Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 4 hrs to fix

      Method getUnselectedPath has 108 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private Path getUnselectedPath(int page,
                                   float centerX,
                                   float nextCenterX,
                                   float joiningFraction,
                                   float dotRevealFraction) {
      Severity: Major
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 4 hrs to fix

        Easel has 33 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public class Easel {

    /**
     * Get a darker version of the specified color (10% darker)
     *
        Severity: Minor
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 4 hrs to fix

          InkPageIndicator has 32 methods (exceeds 20 allowed). Consider refactoring.
          Open

          public class InkPageIndicator extends View implements ViewPager.OnPageChangeListener,
        View.OnAttachStateChangeListener {

    // defaults
    private static final int DEFAULT_DOT_SIZE = 8;                      // dp
          Severity: Minor
          Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 4 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static void tint(@NonNull RadioButton radioButton, @ColorInt int color) {
        final int disabledColor = getDisabledColor(radioButton.getContext());
        ColorStateList sl = new ColorStateList(new int[][]{
                new int[]{android.R.attr.state_enabled, -android.R.attr.state_checked},
                new int[]{android.R.attr.state_enabled, android.R.attr.state_checked},
            Severity: Major
            Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 3 hrs to fix
            app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java on lines 186..207

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 231.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public static void tint(@NonNull CheckBox checkBox, @ColorInt int color) {
        final int disabledColor = getDisabledColor(checkBox.getContext());
        ColorStateList sl = new ColorStateList(new int[][]{
                new int[]{android.R.attr.state_enabled, -android.R.attr.state_checked},
                new int[]{android.R.attr.state_enabled, android.R.attr.state_checked},
            Severity: Major
            Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 3 hrs to fix
            app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java on lines 292..313

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 231.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File CardsAdapter.java has 314 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            package com.androidstudy.andelatrackchallenge.adapter;

import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.content.Context;
            Severity: Minor
            Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java - About 3 hrs to fix

              Method updateBackground has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void updateBackground(int position, float positionOffset) {
        @ColorInt
        int background;
        @ColorInt
        int backgroundNext;
              Severity: Major
              Found in app/src/main/java/com/androidstudy/andelatrackchallenge/WelcomeActivity.java - About 2 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (initialX1 != finalX1) { // rightward retreat
                setFloatValues(initialX1, finalX1);
                // create the reveal animations that will run when the retreat passes them
                for (int i = 0; i < steps; i++) {
                    revealAnimations[i] = new PendingRevealAnimator(was + i,
                Severity: Major
                Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java and 1 other location - About 1 hr to fix
                app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java on lines 723..743

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 126.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else { // (initialX2 != finalX2) leftward retreat
                setFloatValues(initialX2, finalX2);
                // create the reveal animations that will run when the retreat passes them
                for (int i = 0; i < steps; i++) {
                    revealAnimations[i] = new PendingRevealAnimator(was - i,
                Severity: Major
                Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java and 1 other location - About 1 hr to fix
                app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java on lines 703..723

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 126.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method getFlagRes has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @DrawableRes
    public int getFlagRes() {
        switch (code) {
            case "USD":
                return R.drawable.flag_us;
                Severity: Minor
                Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 1 hr to fix

                  Method updateBackground has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private void updateBackground(int position, float positionOffset) {
        @ColorInt
        int background;
        @ColorInt
        int backgroundNext;
                  Severity: Minor
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/WelcomeActivity.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method equals has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;
                  Severity: Minor
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          historyRepository.getDailyHistoryFor(country, ApiClient.BTC)
                .doOnSubscribe(d -> progressBar.setVisibility(View.VISIBLE))
                .doAfterTerminate(() -> progressBar.setVisibility(View.GONE))
                .to(AutoDispose.with(AndroidLifecycleScopeProvider.from(this)).forSingle())
                .subscribe(historyDb -> {
                  Severity: Major
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/ConverterActivity.java and 1 other location - About 1 hr to fix
                  app/src/main/java/com/androidstudy/andelatrackchallenge/ConverterActivity.java on lines 200..210

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 124.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          historyRepository.getDailyHistoryFor(country, ApiClient.ETH)
                .doOnSubscribe(d -> progressBar.setVisibility(View.VISIBLE))
                .doAfterTerminate(() -> progressBar.setVisibility(View.GONE))
                .to(AutoDispose.with(AndroidLifecycleScopeProvider.from(this)).forSingle())
                .subscribe(historyDb -> {
                  Severity: Major
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/ConverterActivity.java and 1 other location - About 1 hr to fix
                  app/src/main/java/com/androidstudy/andelatrackchallenge/ConverterActivity.java on lines 188..198

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 124.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method loadRate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static Single<Country> loadRate(Country oldCountry) {
        long minutesBefore = System.currentTimeMillis() - (10 * 60 * 1000);
        if (oldCountry.refreshedAt > minutesBefore)
            return Single.error(new Throwable("No refresh needed!"));
                  Severity: Minor
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/network/ApiClient.java - About 1 hr to fix

                    Method finishSetup has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private void finishSetup() {
        starImage.setVisibility(country.isFavorite ? View.VISIBLE : View.GONE);
        cryptoEdit.setEnabled(true);
        currencyEdit.setEnabled(true);
        cryptoEdit.setSelection(cryptoEdit.getText().length());
                    Severity: Minor
                    Found in app/src/main/java/com/androidstudy/andelatrackchallenge/ConverterActivity.java - About 1 hr to fix

                      Method setSelectedPage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private void setSelectedPage(int now) {
        if (now == currentPage || dotCenterX == null || dotCenterX.length <= now) return;

        pageChanging = true;
        previousPage = currentPage;
                      Severity: Minor
                      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method createMoveSelectedAnimator has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private ValueAnimator createMoveSelectedAnimator(
            final float moveTo, int was, int now, int steps) {

        // create the actual move animator
        ValueAnimator moveSelected = ValueAnimator.ofFloat(selectedDotX, moveTo);
                      Severity: Minor
                      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language