Sign upLogin

jumaallan/AndelaCryptoApp

View on GitHub
Star
app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java

Summary

Maintainability
D
2 days
Test Coverage

File Easel.java has 370 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.androidstudy.andelatrackchallenge.utils;

/**
 * Created by anonymous on 11/2/17.
 */
Severity: Minor
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 4 hrs to fix

    Easel has 33 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class Easel {

    /**
     * Get a darker version of the specified color (10% darker)
     *
    Severity: Minor
    Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 4 hrs to fix

      Method tint has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public static void tint(@NonNull ProgressBar progressBar, @ColorInt int color, boolean skipIndeterminate) {
        ColorStateList sl = ColorStateList.valueOf(color);
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            progressBar.setProgressTintList(sl);
            progressBar.setSecondaryProgressTintList(sl);
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method tint has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public static void tint(@NonNull SeekBar seekBar, @ColorInt int color) {
        ColorStateList s1 = ColorStateList.valueOf(color);
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            seekBar.setThumbTintList(s1);
            seekBar.setProgressTintList(s1);
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setDrawable has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static void setDrawable(TextView textView, Object editor, Field field, @ColorInt int color,
                                    @DrawableRes int drawableRes) throws IllegalAccessException {
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 35 mins to fix

        Method tintEdgeEffect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @TargetApi(21)
    public static boolean tintEdgeEffect(@NonNull View scrollableView, @ColorInt int color) {
        //http://stackoverflow.com/questions/27104521/android-lollipop-scrollview-edge-effect-color
        boolean outcome = false;
        final String[] edgeGlows = {"mEdgeGlowTop", "mEdgeGlowBottom", "mEdgeGlowLeft", "mEdgeGlowRight"};
        Severity: Minor
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static void tint(@NonNull CheckBox checkBox, @ColorInt int color) {
        final int disabledColor = getDisabledColor(checkBox.getContext());
        ColorStateList sl = new ColorStateList(new int[][]{
                new int[]{android.R.attr.state_enabled, -android.R.attr.state_checked},
                new int[]{android.R.attr.state_enabled, android.R.attr.state_checked},
        Severity: Major
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 3 hrs to fix
        app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java on lines 292..313

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 231.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static void tint(@NonNull RadioButton radioButton, @ColorInt int color) {
        final int disabledColor = getDisabledColor(radioButton.getContext());
        ColorStateList sl = new ColorStateList(new int[][]{
                new int[]{android.R.attr.state_enabled, -android.R.attr.state_checked},
                new int[]{android.R.attr.state_enabled, android.R.attr.state_checked},
        Severity: Major
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 3 hrs to fix
        app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java on lines 186..207

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 231.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public static int getThemeAttrColor(@NonNull Context context, @AttrRes int attributeColor) {
        int[] attrs = new int[]{attributeColor};
        TypedArray ta = context.obtainStyledAttributes(attrs);
        int color = ta.getColor(0, Color.TRANSPARENT);
        ta.recycle();
        Severity: Minor
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 45 mins to fix
        app/src/main/java/com/androidstudy/andelatrackchallenge/utils/ThemeUtils.java on lines 18..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public static int getDarkerColor(@ColorInt int color, float darkerAmount) {
        float[] hsv = new float[3];
        Color.colorToHSV(color, hsv);
        hsv[2] *= darkerAmount;
        return Color.HSVToColor(hsv);
        Severity: Minor
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 35 mins to fix
        app/src/main/java/com/androidstudy/andelatrackchallenge/utils/ThemeUtils.java on lines 26..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status