Sign upLogin

jumaallan/AndelaCryptoApp

View on GitHub
Star
app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java

Summary

Maintainability
F
3 days
Test Coverage

File InkPageIndicator.java has 640 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.androidstudy.andelatrackchallenge.widget;

import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.animation.AnimatorSet;
Severity: Major
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 day to fix

    Method getUnselectedPath has 108 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private Path getUnselectedPath(int page,
                                   float centerX,
                                   float nextCenterX,
                                   float joiningFraction,
                                   float dotRevealFraction) {
    Severity: Major
    Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 4 hrs to fix

      InkPageIndicator has 32 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class InkPageIndicator extends View implements ViewPager.OnPageChangeListener,
        View.OnAttachStateChangeListener {

    // defaults
    private static final int DEFAULT_DOT_SIZE = 8;                      // dp
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 4 hrs to fix

        Method setSelectedPage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private void setSelectedPage(int now) {
        if (now == currentPage || dotCenterX == null || dotCenterX.length <= now) return;

        pageChanging = true;
        previousPage = currentPage;
        Severity: Minor
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createMoveSelectedAnimator has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private ValueAnimator createMoveSelectedAnimator(
            final float moveTo, int was, int now, int steps) {

        // create the actual move animator
        ValueAnimator moveSelected = ValueAnimator.ofFloat(selectedDotX, moveTo);
        Severity: Minor
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 hr to fix

          Method getUnselectedPath has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private Path getUnselectedPath(int page,
                                   float centerX,
                                   float nextCenterX,
                                   float joiningFraction,
                                   float dotRevealFraction) {
          Severity: Minor
          Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onMeasure has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Override
    protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {

        int desiredHeight = getDesiredHeight();
        int height;
          Severity: Minor
          Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 1 hr to fix

            Method onPageScrolled has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
    public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {
        if (isAttachedToWindow) {
            float fraction = positionOffset;
            int currentPosition = pageChanging ? previousPage : currentPage;
            Severity: Minor
            Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getUnselectedPath has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private Path getUnselectedPath(int page,
                                   float centerX,
                                   float nextCenterX,
                                   float joiningFraction,
                                   float dotRevealFraction) {
            Severity: Minor
            Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (initialX1 != finalX1) { // rightward retreat
                setFloatValues(initialX1, finalX1);
                // create the reveal animations that will run when the retreat passes them
                for (int i = 0; i < steps; i++) {
                    revealAnimations[i] = new PendingRevealAnimator(was + i,
              Severity: Major
              Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java and 1 other location - About 1 hr to fix
              app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java on lines 723..743

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 126.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          } else { // (initialX2 != finalX2) leftward retreat
                setFloatValues(initialX2, finalX2);
                // create the reveal animations that will run when the retreat passes them
                for (int i = 0; i < steps; i++) {
                    revealAnimations[i] = new PendingRevealAnimator(was - i,
              Severity: Major
              Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java and 1 other location - About 1 hr to fix
              app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java on lines 703..723

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 126.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      switch (MeasureSpec.getMode(widthMeasureSpec)) {
            case MeasureSpec.EXACTLY:
                width = MeasureSpec.getSize(widthMeasureSpec);
                break;
            case MeasureSpec.AT_MOST:
              Severity: Minor
              Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java and 1 other location - About 55 mins to fix
              app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java on lines 255..265

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      switch (MeasureSpec.getMode(heightMeasureSpec)) {
            case MeasureSpec.EXACTLY:
                height = MeasureSpec.getSize(heightMeasureSpec);
                break;
            case MeasureSpec.AT_MOST:
              Severity: Minor
              Found in app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java and 1 other location - About 55 mins to fix
              app/src/main/java/com/androidstudy/andelatrackchallenge/widget/InkPageIndicator.java on lines 269..279

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status