Sign upLogin

just-paja/radio-drama-queen

View on GitHub
Star
src/soundCategories/components/Category.jsx

Summary

Maintainability
D
1 day
Test Coverage

File Category.jsx has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Card from '@material-ui/core/Card'
import CardActions from '@material-ui/core/CardActions'
import CardContent from '@material-ui/core/CardContent'
import classnames from 'classnames'
import List from '@material-ui/core/List'
Severity: Minor
Found in src/soundCategories/components/Category.jsx - About 2 hrs to fix

    Function render has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render () {
    const {
      boardUuid,
      canDrop,
      classes,
    Severity: Major
    Found in src/soundCategories/components/Category.jsx - About 2 hrs to fix

      Function handleKeyDown has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        handleKeyDown (event) {
    if (event.key === 'ArrowDown') {
      this.moveDown()
    } else if (event.key === 'ArrowUp') {
      this.moveUp()
      Severity: Minor
      Found in src/soundCategories/components/Category.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleKeyDown has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        handleKeyDown (event) {
    if (event.key === 'ArrowDown') {
      this.moveDown()
    } else if (event.key === 'ArrowUp') {
      this.moveUp()
      Severity: Minor
      Found in src/soundCategories/components/Category.jsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          increaseVolume () {
    const { category } = this.props
    if (category.volume < 100) {
      this.props.onVolumeChange(category.uuid, Math.min(category.volume + 5, 100))
    }
        Severity: Major
        Found in src/soundCategories/components/Category.jsx and 1 other location - About 2 hrs to fix
        src/soundCategories/components/Category.jsx on lines 138..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          decreaseVolume () {
    const { category } = this.props
    if (category.volume > 0) {
      this.props.onVolumeChange(category.uuid, Math.max(category.volume - 5, 0))
    }
        Severity: Major
        Found in src/soundCategories/components/Category.jsx and 1 other location - About 2 hrs to fix
        src/soundCategories/components/Category.jsx on lines 145..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

          constructor (props) {
    super(props)
    this.handleFocus = this.handleFocus.bind(this)
    this.handleKeyDown = this.handleKeyDown.bind(this)
  }
        Severity: Major
        Found in src/soundCategories/components/Category.jsx and 8 other locations - About 1 hr to fix
        src/soundStories/components/StoryContextMenu.jsx on lines 12..16
        src/components/ContextMenuControl.jsx on lines 21..25
        src/components/ContextMenuUncontrolled.jsx on lines 13..17
        src/components/InputToggleButton.jsx on lines 13..17
        src/components/withContextMenu.jsx on lines 10..14
        src/soundBoards/components/BoardContextMenu.jsx on lines 13..17
        src/soundCategories/components/SoundSelection.jsx on lines 22..26
        src/soundWorkspaces/components/WorkspaceShortcuts.jsx on lines 13..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const {
      boardUuid,
      canDrop,
      classes,
      connectDropTarget,
        Severity: Major
        Found in src/soundCategories/components/Category.jsx and 1 other location - About 1 hr to fix
        src/electron/paths.js on lines 37..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status