kai-jacobsen/kontentblocks

View on GitHub

Showing 4,293 of 4,293 total issues

The method auth() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    private function auth($postId)
    {
        // verify if this is an auto save routine.
        // If it is our form has not been submitted, so we dont want to do anything
        if (empty($_POST)) {
Severity: Minor
Found in core/Backend/Dynamic/DynamicAreas.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

postTypeMessages accesses the super-global variable $_GET.
Open

    public function postTypeMessages($messages)
    {
        $post = get_post();

        $messages['kb-dyar'] = array(
Severity: Minor
Found in core/Backend/Dynamic/DynamicAreas.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

globalModule accesses the super-global variable $_GET.
Open

    protected function globalModule($gmodule)
    {
        global $post;
        if (empty($gmodule)) {
            wp_die('no template arg provided');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_POST.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_GET.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_GET.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_POST.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

observeQuery accesses the super-global variable $_GET.
Open

    public function observeQuery()
    {
        $request = Utilities::getRequest();
        if (is_numeric($request->query->get('restore_backup', null))) {
            $location = remove_query_arg(array('restore_backup', 'post_id'));
Severity: Minor
Found in core/Extensions/BackupInspect.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

handleUpload accesses the super-global variable $_FILES.
Open

    public static function handleUpload()
    {
        header( 'Content-Type: text/html; charset=UTF-8' );

        if (!defined( 'DOING_AJAX' )) {
Severity: Minor
Found in core/Fields/Definitions/Plupload.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

postTypeMessages accesses the super-global variable $_GET.
Open

    public function postTypeMessages($messages)
    {
        $post = get_post();

        $messages['kb-dyar'] = array(
Severity: Minor
Found in core/Backend/Dynamic/DynamicAreas.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

globalModule accesses the super-global variable $_GET.
Open

    protected function globalModule($gmodule)
    {
        global $post;
        if (empty($gmodule)) {
            wp_die('no template arg provided');

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

auth accesses the super-global variable $_POST.
Open

    private function auth($postId)
    {
        // verify if this is an auto save routine.
        // If it is our form has not been submitted, so we dont want to do anything
        if (empty($_POST)) {
Severity: Minor
Found in core/Backend/Dynamic/DynamicAreas.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

postTypeMessages accesses the super-global variable $_GET.
Open

    public function postTypeMessages($messages)
    {
        $post = get_post();

        $messages['kb-gmd'] = array(

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_POST.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_GET.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

observeQuery accesses the super-global variable $_GET.
Open

    public function observeQuery()
    {
        $request = Utilities::getRequest();
        if (is_numeric($request->query->get('restore_backup', null))) {
            $location = remove_query_arg(array('restore_backup', 'post_id'));
Severity: Minor
Found in core/Extensions/BackupInspect.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

revisionFields accesses the super-global variable $_GET.
Open

    public function revisionFields($return)
    {

        //globals
        global $post, $pagenow;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

The method markVisibility() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
Open

    public function markVisibility(Field $field)
    {

        $field->setVisibility(true);
        $areaContext = $this->entity->getContext()->get('areaContext');
Severity: Minor
Found in core/Fields/ModuleFieldSection.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method parseArgs() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
Open

    private function parseArgs($args, $arguments)
    {
        if (isset($arguments[0]) && is_string($arguments[0])) {
            $args['key'] = $arguments[0];
        }

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method compare() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

    private function compare($first, $group = null, $groups, $value)
    {
        if (is_null($group)) {
            $group = [
                'start' => $first['day'],

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Severity
Category
Status
Source
Language