kanadeko/Kuro

View on GitHub
commands/s.js

Summary

Maintainability
D
2 days
Test Coverage

Function migrate has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.migrate = function() {
    console.log('Starting migration')
    _msg.edit('*Starting migration to kuro v4.1.0, this might take a while depending how many stickers you have. Check the console.*')

    try {
Severity: Minor
Found in commands/s.js - About 1 hr to fix

    Function add has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.add = function(args) {
        if (args[0] === undefined) {
            kuro.edit(_msg, 'No name provided.')
            return
        }
    Severity: Minor
    Found in commands/s.js - About 1 hr to fix

      Function add has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.add = function(args) {
          if (args[0] === undefined) {
              kuro.edit(_msg, 'No name provided.')
              return
          }
      Severity: Minor
      Found in commands/s.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.run = function(msg, args) {
          _msg = msg
      
          if (!(args instanceof Array)) {
              if (_stickers.hasOwnProperty(args)) return this.sendSticker(args)
      Severity: Minor
      Found in commands/s.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function migrate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.migrate = function() {
          console.log('Starting migration')
          _msg.edit('*Starting migration to kuro v4.1.0, this might take a while depending how many stickers you have. Check the console.*')
      
          try {
      Severity: Minor
      Found in commands/s.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          if (_stickers.hasOwnProperty(args[0])) return this.sendSticker(args[0])
      Severity: Major
      Found in commands/s.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (args[0] === 'migrate') return this.migrate()
        Severity: Major
        Found in commands/s.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (args[0] === 'list') return this.list()
          Severity: Major
          Found in commands/s.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                if (args[0] === 'ren') return this.ren(newargs)
            Severity: Major
            Found in commands/s.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              exports.ren = function(args) {
                  if (args[0] === undefined) return kuro.edit(_msg, 'No source sticker supplied.')
                  if (args[1] === undefined) return kuro.edit(_msg, 'No destination sticker supplied.')
              
                  if (args[0] in _stickers) {
              Severity: Major
              Found in commands/s.js and 1 other location - About 1 day to fix
              commands/tag.js on lines 93..109

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 240.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      kuro.db.table(_table)
                          .where('name', args[0])
                          .del()
                          .then(() => {
                              delete (_stickers[args[0]])
              Severity: Major
              Found in commands/s.js and 1 other location - About 2 hrs to fix
              commands/tag.js on lines 80..87

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  for (let sticker in _stickers) {
                      if ({}.hasOwnProperty.call(_stickers, sticker)) {
                          list = `${list}${sticker}, `
                      }
                  }
              Severity: Minor
              Found in commands/s.js and 1 other location - About 55 mins to fix
              commands/tag.js on lines 113..117

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status