Sign upLogin

kanadeko/Kuro

View on GitHub
Star

Showing 36 of 36 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

exports.ren = function(args) {
    if (args[0] === undefined) return kuro.edit(_msg, 'No source tag supplied.')
    if (args[1] === undefined) return kuro.edit(_msg, 'No destination tag supplied.')

    if (args[0] in _tags) {
Severity: Major
Found in commands/tag.js and 1 other location - About 1 day to fix
commands/s.js on lines 156..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

exports.ren = function(args) {
    if (args[0] === undefined) return kuro.edit(_msg, 'No source sticker supplied.')
    if (args[1] === undefined) return kuro.edit(_msg, 'No destination sticker supplied.')

    if (args[0] in _stickers) {
Severity: Major
Found in commands/s.js and 1 other location - About 1 day to fix
commands/tag.js on lines 93..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function secondsToString(seconds) {
    seconds = Math.trunc(seconds)
    let numdays = Math.floor((seconds % 31536000) / 86400)
    let numhours = Math.floor(((seconds % 31536000) % 86400) / 3600)
    let numminutes = Math.floor((((seconds % 31536000) % 86400) % 3600) / 60)
Severity: Major
Found in commands/stats.js and 1 other location - About 5 hrs to fix
commands/uptime.js on lines 14..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function secondsToString(seconds) {
    seconds = Math.trunc(seconds)
    let numdays = Math.floor((seconds % 31536000) / 86400)
    let numhours = Math.floor(((seconds % 31536000) % 86400) / 3600)
    let numminutes = Math.floor((((seconds % 31536000) % 86400) % 3600) / 60)
Severity: Major
Found in commands/uptime.js and 1 other location - About 5 hrs to fix
commands/stats.js on lines 34..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

exports.run = function(msg, args) {
    let search = args.toString().replace(/,/g, ' ')
    kitsu.searchManga(search)
        .then(result => {
            if (result.length === 0) {
Severity: Major
Found in commands/manga.js and 1 other location - About 5 hrs to fix
commands/anime.js on lines 7..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

exports.run = function(msg, args) {
    let search = args.toString().replace(/,/g, ' ')
    kitsu.searchAnime(search)
        .then(result => {
            if (result.length === 0) {
Severity: Major
Found in commands/anime.js and 1 other location - About 5 hrs to fix
commands/manga.js on lines 7..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function run has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.run = function(msg, args) {
    msg.edit('Loading...')

    const request = require('request')
    const parseString = require('xml2js').parseString
Severity: Major
Found in commands/mal.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            kuro.db.table(_table)
            .where('name', args[0])
            .del()
            .then(() => {
                delete (_tags[args[0]])
    Severity: Major
    Found in commands/tag.js and 1 other location - About 2 hrs to fix
    commands/s.js on lines 143..150

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            kuro.db.table(_table)
            .where('name', args[0])
            .del()
            .then(() => {
                delete (_stickers[args[0]])
    Severity: Major
    Found in commands/s.js and 1 other location - About 2 hrs to fix
    commands/tag.js on lines 80..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.run = function(msg, args) {
    if (!args[0]) return msg.delete()

    let id = args[0].replace(/<@!|<@/, '').replace('>', '')
    let user = msg.guild.members.get(id)
    Severity: Minor
    Found in commands/user.js - About 1 hr to fix

      Function migrate has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.migrate = function() {
    console.log('Starting migration')
    _msg.edit('*Starting migration to kuro v4.1.0, this might take a while depending how many stickers you have. Check the console.*')

    try {
      Severity: Minor
      Found in commands/s.js - About 1 hr to fix

        Function prepareEmbed has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function prepareEmbed(msg, item) {
    const { slug, synopsis, titles, popularityRank, posterImage, chapterCount, volumeCount, mangaType } = item
    const url = `https://kitsu.io/manga/${slug}`

    msg.edit('', {
        Severity: Minor
        Found in commands/manga.js - About 1 hr to fix

          Function add has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.add = function(args) {
    if (args[0] === undefined) {
        kuro.edit(_msg, 'No name provided.')
        return
    }
          Severity: Minor
          Found in commands/s.js - About 1 hr to fix

            Function add has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.add = function(args) {
    if (args[0] === undefined) {
        kuro.edit(_msg, 'No name provided.')
        return
    }
            Severity: Minor
            Found in commands/s.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.run = function(msg, args) {
    if (args[0] === undefined) return msg.delete()
    if (!args[0].startsWith('<:')) return kuro.edit(msg, 'Not a valid emote')

    let id = args[0].substring(args[0].lastIndexOf(':') + 1, args[0].lastIndexOf('>'))
            Severity: Minor
            Found in commands/emote.js - About 1 hr to fix

              Function prepareEmbed has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function prepareEmbed(msg, item) {
    const { slug, synopsis, titles, averageRating, posterImage, episodeCount, showType } = item
    const url = `https://kitsu.io/anime/${slug}`

    msg.edit('', {
              Severity: Minor
              Found in commands/anime.js - About 1 hr to fix

                Function run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                exports.run = function(msg) {
    msg.delete()
    msg.channel.send('👀').then(msg => {
        setTimeout(() => {
            msg.edit('<:eyes2:248874616142036992>').then(msg => {
                Severity: Minor
                Found in commands/eyes.js - About 1 hr to fix

                  Function run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.run = function(msg, args) {
    _msg = msg

    if (!(args instanceof Array)) {
        if (_stickers.hasOwnProperty(args)) return this.sendSticker(args)
                  Severity: Minor
                  Found in commands/s.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      for (let sticker in _stickers) {
        if ({}.hasOwnProperty.call(_stickers, sticker)) {
            list = `${list}${sticker}, `
        }
    }
                  Severity: Minor
                  Found in commands/s.js and 1 other location - About 55 mins to fix
                  commands/tag.js on lines 113..117

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      for (let tag in _tags) {
        if ({}.hasOwnProperty.call(_tags, tag)) {
            list = `${list} ${tag}, `
        }
    }
                  Severity: Minor
                  Found in commands/tag.js and 1 other location - About 55 mins to fix
                  commands/s.js on lines 177..181

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language