kanalumaddela/laravel-steam-login

View on GitHub

Showing 6 of 6 total issues

SteamLogin has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class SteamLogin implements SteamLoginInterface
{
    /**
     * Steam OpenID URL.
     *
Severity: Minor
Found in src/SteamLogin.php - About 2 hrs to fix

    File SteamLogin.php has 271 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*
     * Laravel Steam Login.
     *
     * @link      https://www.maddela.org
    Severity: Minor
    Found in src/SteamLogin.php - About 2 hrs to fix

      Method parseApiProfileData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected static function parseApiProfileData($body): array
          {
              $json = @json_decode($body, true);
              $json = $json['response']['players'][0] ?? null;
      
      
      Severity: Minor
      Found in src/SteamUser.php - About 1 hr to fix

        Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function validate(): ?string
            {
                if (!$this->request->has('openid_signed') || $this->request->query('openid_claimed_id') !== $this->request->query('openid_identity')) {
                    return null;
                }
        Severity: Minor
        Found in src/SteamLogin.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setRedirectTo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function setRedirectTo(string $redirectTo = null, bool $checkRoutes = true): self
            {
                if (empty($redirectTo)) {
                    $redirectTo = $this->isLaravel() ? $this->urlGenerator->previous('/') : $this->urlGenerator->to('/');
                }
        Severity: Minor
        Found in src/SteamLogin.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function authenticate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function authenticate()
            {
                $valid = $this->steam->validated();
        
                if ($valid && !empty($result = $this->authenticated($this->request, $this->steam->getPlayer()))) {
        Severity: Minor
        Found in src/Http/Controllers/AbstractSteamLoginController.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language