include/sending.rb
Method list_for
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def list_for(resource_url, resource_url_with_dates, resource_name, args = {})
# OptOut counting does not work :-( We will have to do the date request to fix this...
# If date-arguments are given, we will have to use the date request.
if args[:date_from] || args[:date_to] || resource_name == "OptOut"
return list_for_with_dates(resource_url_with_dates, resource_name, args)
Method list_for
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def list_for(resource_url, resource_url_with_dates, resource_name, args = {})
# OptOut counting does not work :-( We will have to do the date request to fix this...
# If date-arguments are given, we will have to use the date request.
if args[:date_from] || args[:date_to] || resource_name == "OptOut"
return list_for_with_dates(resource_url_with_dates, resource_name, args)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"