Sign upLogin

keboola/juicer

View on GitHub
Star
src/Parser/Json.php

Summary

Maintainability
A
2 hrs
Test Coverage
C
76%

Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(
        LoggerInterface $logger,
        array $metadata,
        int $compatLevel,
        int $cacheMemoryLimit = 2000000
Severity: Minor
Found in src/Parser/Json.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(
        LoggerInterface $logger,
        array $metadata,
        int $compatLevel,
        int $cacheMemoryLimit = 2000000
Severity: Minor
Found in src/Parser/Json.php - About 1 hr to fix

    The class Json has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class Json implements ParserInterface
{
    public const LEGACY_VERSION = 2;
    public const LATEST_VERSION = 3;
    Severity: Minor
    Found in src/Parser/Json.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    There are no issues that match your filters.

    Category
    Status