Sign upLogin

kennethkalmer/powerdns-on-rails

View on GitHub
Star
app/models/macro.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method apply_to has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def apply_to( domain )
    Record.batch do
      macro_steps.each do |step|

        if step.action == 'create'
Severity: Minor
Found in app/models/macro.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method macro_change has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def macro_change( domain, step )
    changed = false

    domain.records.all( :conditions => { :type => step.record_type }).each do |record|
      next unless record.shortname == step.name
Severity: Minor
Found in app/models/macro.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status