Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star

Showing 200 of 200 total issues

Method upload_catalog_translation has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def upload_catalog_translation(catalog_translation, locale, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})
Severity: Major
Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

    Method upload_invoice_template has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def upload_invoice_template(invoice_template, is_manual_pay, delete_if_exists, user = nil, reason = nil, comment = nil, options = {})
    Severity: Major
    Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

      Method destroy has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def destroy(payment_method_id, set_auto_pay_off = false, force_default_deletion = false, user = nil, reason = nil, comment = nil, options = {})
      Severity: Major
      Found in lib/killbill_client/models/payment_method.rb - About 50 mins to fix

        Method refund has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def refund(payment_id, amount, adjustments = nil, user = nil, reason = nil, comment = nil, options = {})
        Severity: Major
        Found in lib/killbill_client/models/invoice_payment.rb - About 50 mins to fix

          Method trigger_invoice_group_run has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def trigger_invoice_group_run(account_id, target_date = nil, plugin_property = nil, user = nil, reason = nil, comment = nil, options = {})
          Severity: Major
          Found in lib/killbill_client/models/invoice.rb - About 50 mins to fix

            Method trigger_invoice_generation_for_parked_accounts has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def trigger_invoice_generation_for_parked_accounts(offset = 0, limit = 100, plugin_property = [], user = nil, reason = nil, comment = nil, options = {})
            Severity: Major
            Found in lib/killbill_client/models/admin.rb - About 50 mins to fix

              Method credit_by_external_key has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def credit_by_external_key(account_external_key, payment_method_id = nil, user = nil, reason = nil, comment = nil, options = {}, refresh_options = nil)
              Severity: Major
              Found in lib/killbill_client/models/transaction.rb - About 50 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def create_tax_item(auto_commit = false, user = nil, reason = nil, comment = nil, options = {})
        created_tax_item = self.class.post "#{Invoice::KILLBILL_API_INVOICES_PREFIX}/taxes/#{account_id}",
                                               [to_hash].to_json,
                                               {:autoCommit => auto_commit},
                                               {
                Severity: Minor
                Found in lib/killbill_client/models/invoice_item.rb and 1 other location - About 50 mins to fix
                lib/killbill_client/models/invoice_item.rb on lines 45..54

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def create(auto_commit = false, user = nil, reason = nil, comment = nil, options = {})
        created_invoice_item = self.class.post "#{Invoice::KILLBILL_API_INVOICES_PREFIX}/charges/#{account_id}",
                                               [to_hash].to_json,
                                               {:autoCommit => auto_commit},
                                               {
                Severity: Minor
                Found in lib/killbill_client/models/invoice_item.rb and 1 other location - About 50 mins to fix
                lib/killbill_client/models/invoice_item.rb on lines 89..98

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def resume(requested_date = nil, user = nil, reason = nil, comment = nil, options = {})

        params                 = {}
        params[:requestedDate] = requested_date unless requested_date.nil?
        self.class.put "#{KILLBILL_API_BUNDLES_PREFIX}/#{@bundle_id}/resume",
                Severity: Minor
                Found in lib/killbill_client/models/bundle.rb and 1 other location - About 50 mins to fix
                lib/killbill_client/models/bundle.rb on lines 83..94

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def pause(requested_date = nil, user = nil, reason = nil, comment = nil, options = {})

        params                 = {}
        params[:requestedDate] = requested_date unless requested_date.nil?
        self.class.put "#{KILLBILL_API_BUNDLES_PREFIX}/#{@bundle_id}/pause",
                Severity: Minor
                Found in lib/killbill_client/models/bundle.rb and 1 other location - About 50 mins to fix
                lib/killbill_client/models/bundle.rb on lines 98..109

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  module Model
    class InvoiceAttributes < Resource
      attribute :amount
      attribute :currency
      attribute :status
                Severity: Minor
                Found in lib/killbill_client/models/gen/invoice_attributes.rb and 1 other location - About 45 mins to fix
                lib/killbill_client/models/gen/invoice_payment_transaction_attributes.rb on lines 29..50

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 41.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  module Model
    class InvoicePaymentTransactionAttributes < Resource
      attribute :transaction_id
      attribute :transaction_external_key
      attribute :payment_id
                Severity: Minor
                Found in lib/killbill_client/models/gen/invoice_payment_transaction_attributes.rb and 1 other location - About 45 mins to fix
                lib/killbill_client/models/gen/invoice_attributes.rb on lines 29..50

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 41.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method find_by_id has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def find_by_id(payment_method_id, included_deleted = false, with_plugin_info = false, plugin_property = [], audit = 'NONE', options = {})
                Severity: Minor
                Found in lib/killbill_client/models/payment_method.rb - About 45 mins to fix

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                        def chargeback(user = nil, reason = nil, comment = nil, options = {}, refresh_options = nil)
        follow_location = delete_follow_location(options)
        refresh_payment_with_failure_handling(follow_location, refresh_options || options) do
          self.class.post "#{follow_up_path(payment_id)}/chargebacks",
                          to_json,
                  Severity: Major
                  Found in lib/killbill_client/models/transaction.rb and 3 other locations - About 45 mins to fix
                  lib/killbill_client/models/transaction.rb on lines 89..99
                  lib/killbill_client/models/transaction.rb on lines 168..178
                  lib/killbill_client/models/transaction.rb on lines 182..192

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method transfer has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def transfer(requested_date = nil, billing_policy = nil, user = nil, reason = nil, comment = nil, options = {})
                  Severity: Minor
                  Found in lib/killbill_client/models/bundle.rb - About 45 mins to fix

                    Method trigger_node_command has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            def trigger_node_command(node_command, local_node_only, user = nil, reason = nil, comment = nil, options = {})
                    Severity: Minor
                    Found in lib/killbill_client/models/nodes_info.rb - About 45 mins to fix

                      Method create has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def create(user = nil, reason = nil, comment = nil, requested_date = nil, call_completion = false, options = {})
                      Severity: Minor
                      Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

                        Method find_in_batches_by_search_key has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                def find_in_batches_by_search_key(search_key, offset = 0, limit = 100, with_balance = false, with_balance_and_cba = false, options = {})
                        Severity: Minor
                        Found in lib/killbill_client/models/account.rb - About 45 mins to fix

                          Method find_by_transaction_external_key has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  def find_by_transaction_external_key(external_key, with_plugin_info = false, with_attempts = false, plugin_property = [], audit = 'NONE', options = {})
                          Severity: Minor
                          Found in lib/killbill_client/models/payment.rb - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language