Sign upLogin

killbill/killbill-client-ruby

View on GitHub
Star

Showing 200 of 200 total issues

Method find_by_external_key has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def find_by_external_key(external_key, included_deleted = false, with_plugin_info = false, plugin_property = [], audit = 'NONE', options = {})
Severity: Minor
Found in lib/killbill_client/models/payment_method.rb - About 45 mins to fix

    Method trigger_invoice_dry_run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def trigger_invoice_dry_run(account_id, target_date, upcoming_invoice_target_date, plugin_property = [], user = nil, reason = nil, comment = nil, options = {})

          dry_run = InvoiceDryRunAttributes.new
          dry_run.dry_run_type = upcoming_invoice_target_date ? 'UPCOMING_INVOICE' : 'TARGET_DATE'
    Severity: Minor
    Found in lib/killbill_client/models/invoice.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_bulk_subscriptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def create_bulk_subscriptions(bulk_subscription_list, user = nil, reason = nil, comment = nil, entitlement_date = nil, billing_date = nil, call_completion_sec = nil, options = {})

          params = {}
          params[:callCompletion] = true unless call_completion_sec.nil?
          params[:callTimeoutSec] = call_completion_sec unless call_completion_sec.nil?
    Severity: Minor
    Found in lib/killbill_client/models/bulk_subscription.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method from_json has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def from_json(resource_class, json)
          # e.g. DELETE
          return nil if json.nil? or json.size == 0
          data = JSON.parse json
    Severity: Minor
    Found in lib/killbill_client/models/resource.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_by_transaction_id has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def find_by_transaction_id(transaction_id, with_plugin_info = false, with_attempts = false, plugin_property = [], audit = 'NONE', options = {})
    Severity: Minor
    Found in lib/killbill_client/models/payment.rb - About 45 mins to fix

      Method add_payment_state_machine has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def add_payment_state_machine(plugin_name, state_machine_config, user = nil, reason = nil, comment = nil, options = {})
      Severity: Minor
      Found in lib/killbill_client/models/tenant.rb - About 45 mins to fix

        Method update_transaction_state has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def update_transaction_state(status, control_plugin_name = nil, user, reason, comment, options)
        Severity: Minor
        Found in lib/killbill_client/models/transaction.rb - About 45 mins to fix

          Method upload_tenant_user_key_value has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def upload_tenant_user_key_value(key_name, key_value, user = nil, reason = nil, comment = nil, options = {})
          Severity: Minor
          Found in lib/killbill_client/models/tenant.rb - About 45 mins to fix

            Method cancel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def cancel(user = nil, reason = nil, comment = nil, requested_date = nil, entitlementPolicy = nil, billing_policy = nil, use_requested_date_for_billing = nil, options = {})
        params                              = {}
        params[:requestedDate]              = requested_date unless requested_date.nil?
        params[:billingPolicy]              = billing_policy unless billing_policy.nil?
        params[:entitlementPolicy]          = entitlementPolicy unless entitlementPolicy.nil?
            Severity: Minor
            Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method update_quantity has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def update_quantity(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_new_quantity_with_past_effective_date = nil, options = {})
            Severity: Minor
            Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                    def refund(user = nil, reason = nil, comment = nil, options = {}, refresh_options = nil)
        follow_location = delete_follow_location(options)
        refresh_payment_with_failure_handling(follow_location, refresh_options || options) do
          self.class.post "#{follow_up_path(payment_id)}/refunds",
                          to_json,
              Severity: Major
              Found in lib/killbill_client/models/transaction.rb and 3 other locations - About 45 mins to fix
              lib/killbill_client/models/transaction.rb on lines 136..146
              lib/killbill_client/models/transaction.rb on lines 168..178
              lib/killbill_client/models/transaction.rb on lines 182..192

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method upload_tenant_plugin_config has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def upload_tenant_plugin_config(plugin_name, plugin_config, user = nil, reason = nil, comment = nil, options = {})
              Severity: Minor
              Found in lib/killbill_client/models/tenant.rb - About 45 mins to fix

                Method combo_payment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                      def combo_payment(user, reason, comment, options, refresh_options = nil)
        follow_location = true
        follow_location = options.delete(:follow_location) if options.has_key?(:follow_location)
        begin
          created_transaction = self.class.post "#{Payment::KILLBILL_API_PAYMENTS_PREFIX}/combo",
                Severity: Minor
                Found in lib/killbill_client/models/combo_transaction.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method set_default has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def set_default(payment_method_id, account_id, user = nil, reason = nil, comment = nil, options = {})
                Severity: Minor
                Found in lib/killbill_client/models/payment_method.rb - About 45 mins to fix

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                        def chargeback_reversals(user = nil, reason = nil, comment = nil, options = {}, refresh_options = nil)
        follow_location = delete_follow_location(options)
        refresh_payment_with_failure_handling(follow_location, refresh_options || options) do
        self.class.post "#{follow_up_path(payment_id)}/chargebackReversals",
                        to_json,
                  Severity: Major
                  Found in lib/killbill_client/models/transaction.rb and 3 other locations - About 45 mins to fix
                  lib/killbill_client/models/transaction.rb on lines 89..99
                  lib/killbill_client/models/transaction.rb on lines 136..146
                  lib/killbill_client/models/transaction.rb on lines 168..178

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method find_in_batches_by_search_type_name has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def find_in_batches_by_search_type_name(object_type, field_name, field_value, offset = 0, limit = 100, options = {})
                  Severity: Minor
                  Found in lib/killbill_client/models/custom_field.rb - About 45 mins to fix

                    Method trigger_invoice has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            def trigger_invoice(account_id, target_date, user = nil, reason = nil, comment = nil, options = {})
                    Severity: Minor
                    Found in lib/killbill_client/models/invoice.rb - About 45 mins to fix

                      Method update_bcd has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def update_bcd(user = nil, reason = nil, comment = nil, effective_from_date = nil, force_past_effective_date = nil, options = {})
                      Severity: Minor
                      Found in lib/killbill_client/models/subscription.rb - About 45 mins to fix

                        Method increment_kb_clock has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                def increment_kb_clock(days, weeks, months, years, time_zone, options)
                        Severity: Minor
                        Found in lib/killbill_client/models/admin.rb - About 45 mins to fix

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                                def chargeback_by_external_key(user = nil, reason = nil, comment = nil, options = {}, refresh_options = nil)
        follow_location = delete_follow_location(options)
        refresh_payment_with_failure_handling(follow_location, refresh_options || options) do
        self.class.post "#{follow_up_path(payment_id)}/chargebacks",
                        to_json,
                          Severity: Major
                          Found in lib/killbill_client/models/transaction.rb and 3 other locations - About 45 mins to fix
                          lib/killbill_client/models/transaction.rb on lines 89..99
                          lib/killbill_client/models/transaction.rb on lines 136..146
                          lib/killbill_client/models/transaction.rb on lines 182..192

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 40.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language