kiwitcms/Kiwi

View on GitHub

Showing 243 of 379 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  document.getElementById('id_version').onchange = function () {
    $('#id_version').selectpicker('refresh')
    populateBuild()
  }
Severity: Major
Found in tcms/bugs/static/bugs/js/mutable.js and 3 other locations - About 30 mins to fix
tcms/bugs/static/bugs/js/mutable.js on lines 14..17
tcms/testcases/static/testcases/js/mutable.js on lines 18..21
tcms/testplans/static/testplans/js/mutable.js on lines 21..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  document.getElementById('id_product').onchange = function () {
    $('#id_product').selectpicker('refresh')
    populateProductCategory()
  }
Severity: Major
Found in tcms/testcases/static/testcases/js/mutable.js and 3 other locations - About 30 mins to fix
tcms/bugs/static/bugs/js/mutable.js on lines 14..17
tcms/bugs/static/bugs/js/mutable.js on lines 19..22
tcms/testplans/static/testplans/js/mutable.js on lines 21..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return HttpResponseRedirect(request.META.get("HTTP_REFERER", "/"))
Severity: Major
Found in tcms/testcases/views.py - About 30 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      document.getElementById('id_product').onchange = function () {
        $('#id_product').selectpicker('refresh')
        populateVersion()
      }
    Severity: Major
    Found in tcms/bugs/static/bugs/js/mutable.js and 3 other locations - About 30 mins to fix
    tcms/bugs/static/bugs/js/mutable.js on lines 19..22
    tcms/testcases/static/testcases/js/mutable.js on lines 18..21
    tcms/testplans/static/testplans/js/mutable.js on lines 21..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      document.getElementById('id_product').onchange = function () {
        $('#id_product').selectpicker('refresh')
        populateProductVersion()
      }
    Severity: Major
    Found in tcms/testplans/static/testplans/js/mutable.js and 3 other locations - About 30 mins to fix
    tcms/bugs/static/bugs/js/mutable.js on lines 14..17
    tcms/bugs/static/bugs/js/mutable.js on lines 19..22
    tcms/testcases/static/testcases/js/mutable.js on lines 18..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function get_case_notification_recipients has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_case_notification_recipients(case):
        recipients = set()
    
        if case.emailing.auto_to_case_author:
            recipients.add(case.author.email)
    Severity: Minor
    Found in tcms/testcases/helpers/email.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def add_link(values, update_tracker=False, **kwargs):
        """
        .. function:: RPC TestExecution.add_link(values)
    
            Add new URL link to a TestExecution
    Severity: Minor
    Found in tcms/rpc/api/testexecution.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function drawChart has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function drawChart () {
      const query = {}
    
      const productIds = $('#id_product').val()
      if (productIds.length) {
    Severity: Minor
    Found in tcms/telemetry/static/telemetry/js/testing/execution-trends.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_install_requires has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_install_requires(path):
        requires = []
        links = []
    
        with open(path, "r", encoding="utf-8") as file:
    Severity: Minor
    Found in setup.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateBuildSelectFromVersion has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function updateBuildSelectFromVersion (keepFirst) {
      const updateCallback = function (data) {
        updateSelect(data, '#id_build', 'id', 'name', 'version__value')
      }
    
    
    Severity: Minor
    Found in tcms/static/js/utils.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function request_host_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def request_host_link(request, domain_name=None):
        protocol = "https://"
        if "runserver" in sys.argv:
            protocol = "http://"
    
    
    Severity: Minor
    Found in tcms/core/utils/__init__.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function open has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def open(self):
            for rootpath, _dirs, files in os.walk(self.project_root, topdown=False):
                for file_name in files:
                    if file_name.endswith((".html", ".txt")):
                        self.all_template_files.add(
    Severity: Minor
    Found in kiwi_lint/similar_string.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function drawPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function drawPage () {
      const query = {}
    
      const productIds = $('#id_product').val()
      if (productIds.length) {
    Severity: Minor
    Found in tcms/telemetry/static/telemetry/js/testing/test-case-health.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Don't use IDs in selectors.
    Open

    header#grp-header { position: static; }
    Severity: Minor
    Found in tcms/static/style/admin.css by csslint

    Element (nav.navbar-default) is overqualified, just use .navbar-default without element name.
    Open

    nav.navbar-default { border-top-color: #3C8D2C; }

    Don't use IDs in selectors.
    Open

    #grp-content { top: 0; }
    Severity: Minor
    Found in tcms/static/style/admin.css by csslint

    Element (li.grp-danger) is overqualified, just use .grp-danger without element name.
    Open

    .grp-messagelist > li.grp-danger {

    Rule doesn't have all its properties in alphabetical order.
    Open

    .progress-bar, .progress-bar-warning {

    Use of !important
    Open

        content: none !important;

    Using width with padding-left can sometimes make elements larger than you expect.
    Open

        padding-left: 1px;
    Severity
    Category
    Status
    Source
    Language